Repository navigation
Conversation
aviralni
force-pushed
the
pyzes_power_apis
branch
2 times, most recently
from
September 23, 2026 10:48
6b09af3 to
143c652
Compare
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Moderate issues can cause unintended hardware changes, invalid inputs, or silently skipped operations.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 2
Open (3)
What changed in this PR
Adds five power-management APIs to the Python Sysman binding, including tests, examples, CLI controls, and documentation.
Changes:
- Adds usage, extended-limit, and energy-threshold wrappers.
- Adds unit and black-box coverage.
- Documents the new APIs.
| File | Description |
|---|---|
bindings/sysman/python/test/unit_tests/test_power.py |
Tests the new power API wrappers. |
bindings/sysman/python/source/pyzes.py |
Adds ctypes structures and API wrappers. |
bindings/sysman/python/source/examples/pyzes_black_box_test.py |
Adds runtime checks and setter CLI options. |
bindings/sysman/python/README.md |
Documents the newly supported APIs. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Added following power APIs to python binding: 1. zesPowerGetUsage 2. zesPowerGetLimitsExt2 3. zesPowerSetLimitsExt2 4. zesPowerGetEnergyThreshold 5. zesPowerSetEnergyThreshold Along with the zes_energy_threshold_t structure, unit tests, power black box test coverage and README updates. Related-To: SYSM-430 Signed-off-by: Aviral Nigam <aviral.nigam@intel.com>
…in pyzes black box test
… black box test canControl only reports whether the power limits can be changed, and energy threshold support is reported independently. Check each setter against its own capability, so --set-energy-threshold is not skipped on a domain that supports thresholds but not power limit control. Related-To: SYSM-430 Signed-off-by: Aviral Nigam <aviral.nigam@intel.com>
aviralni
force-pushed
the
pyzes_power_apis
branch
from
October 8, 2026 07:15
91e2721 to
8cd1de4
Compare
zello_sysman sets a power limit with -o --setlimit --global-limit <deviceNo limit>. Replace --set-global-limit DEVICE LIMIT_MW with the same two options so both tools take the same command line; they must be given together. Related-To: SYSM-430 Signed-off-by: Aviral Nigam <aviral.nigam@intel.com>
Added following power APIs to python binding: 1. zesPowerGetUsage 2. zesPowerGetLimitsExt2 3. zesPowerSetLimitsExt2 4. zesPowerGetEnergyThreshold 5. zesPowerSetEnergyThreshold Along with the zes_energy_threshold_t structure, unit tests, power black box test coverage and README updates. Related-To: SYSM-430 Signed-off-by: Aviral Nigam <aviral.nigam@intel.com>
joshuaranjan
previously approved these changes
Oct 9, 2026
shubskmr
reviewed
Oct 9, 2026
| | `zesPowerGetProperties` | Power | 0.1.2 | None | | ||
| | `zesPowerGetLimitsExt` | Power | 0.1.2 | Extended power limits API | | ||
| | `zesPowerSetLimitsExt` | Power | 0.1.2 | Linux: Requires superuser or write permissions for telem nodes | | ||
| | `zesPowerGetUsage` | Power | 0.1.3 | None | |
Contributor
There was a problem hiding this comment.
this needs super user too no?
Contributor
Author
There was a problem hiding this comment.
Yes. Thanks or pointing out.
There was a problem hiding this comment.
@aviralni
Please check all the new APIs..
Create a script to verify this by running blackbox test (on the actual machine)
shubskmr
reviewed
Oct 9, 2026
shubskmr
left a comment
shubskmr
left a comment
Contributor
There was a problem hiding this comment.
can you please add the jira in the commit message?
are the output attached there?
Contributor
Author
Done. Yes outputs are attached |
Added following power APIs to python binding: 1. zesPowerGetUsage 2. zesPowerGetLimitsExt2 3. zesPowerSetLimitsExt2 4. zesPowerGetEnergyThreshold 5. zesPowerSetEnergyThreshold Along with the zes_energy_threshold_t structure, unit tests, power black box test coverage and README updates. Related-To: SYSM-430 Signed-off-by: Aviral Nigam <aviral.nigam@intel.com>
aviralni
force-pushed
the
pyzes_power_apis
branch
from
October 9, 2026 12:31
72f0c0c to
9f65461
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feature: Add more power APIs to L0 Sysman python binding
Added following power APIs to python binding:
Related-To: SYSM-430
Signed-off-by: Aviral Nigam aviral.nigam@intel.com