Repository navigation
Provide screen reader alerts for selecting items in browse table. Fix #1141 - #1161
Merged
Merged
Conversation
This ensures Voiceover reads the string in the correct order, also addresses awkward plural phrasing when only one item selected. (#1141)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This turns the selected items text into an
aria-liveregion so that screen readers announce changes to the item browse table. The text has been adjusted to "Items selected: #", as Voiceover was reading the previous text's updated number in the wrong order. This also gets around the awkward grammar of "1 selected items".