[martin-mat]

Fixes #589.

runWebUIAndNFConfig created its context with context.WithCancel(context.Background()), and nothing cancelled it on a signal. So the NFConfig server's graceful shutdown (srv.Shutdown with a 5 s timeout) never ran on SIGTERM: run as PID 1 the process was ended by the signal at once, and under a shell it was killed after the grace period.

• server.go: the context comes from signal.NotifyContext(context.Background(), os.Interrupt, syscall.SIGTERM). When NFConfig returns, for whatever reason, the WebUI is stopped too, and the function waits for it before returning, so the process exits 0.
• backend/webui_service/webui_init.go: the WebUI server is shut down on cancellation, with the same 5 s timeout as the NFConfig server. http.ErrServerClosed from its ListenAndServe is no longer passed to Fatalln, which would otherwise end the shutdown with exit 1.
• server_test.go: a test sends the process SIGTERM and checks that both parts stop and runWebUIAndNFConfig returns nil.

Checked with go test ./... (the new test three times in a row) and golangci-lint with the repository's configuration. On kind, with the image built from this branch running in the SD-Core chart as PID 1 (exec, as omec-project/sdcore-helm-charts#192 does for other functions): simapp's provisioning against it succeeds, and on a scale-down the pod exits with code 0 after 0.9 s, logging NFConfig context cancelled, shutting down server., WebUI shutting down due to context cancel and WebUI and NFConfig stopped. Before, it exited with 143 at once and logged nothing.

The metrics server on :8080 still uses http.ListenAndServe without a handle and is simply ended with the process.

🤖 Generated with Claude Code

[Copilot]

Copilot review overview

🟡 Changes recommended

The WebUI shutdown path has a startup race that can bypass Shutdown.

Review effort: Balanced
Findings: 1

Open (1)

• Ensure cancellation synchronizes server configuration before Start returns · New

What changed in this PR

Adds graceful SIGTERM and interrupt handling so WebUI and NFConfig shut down cleanly.

Changes:

• Cancels both services on termination signals and waits for WebUI shutdown.
• Gracefully shuts down the WebUI HTTP server.
• Adds SIGTERM lifecycle coverage.

File	Description
server.go	Coordinates signal cancellation and service shutdown.
server_test.go	Tests SIGTERM handling.
backend/​webui_service/​webui_init.go	Adds WebUI server shutdown logic.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

Copilot review overview

🟢 Approval recommended

Signal handling, coordinated shutdown, error handling, and regression coverage are consistent and complete.

Review effort: Balanced
Findings: None

Resolved since last review (1)

• Ensure cancellation synchronizes server configuration before Start returns

[gab-arrobo]

@martin-mat, please see this comment: omec-project/simapp#300 (comment)

[Copilot]

Copilot review overview

🟡 Changes recommended

The unrelated version promotion would trigger the release pipeline and publish 3.1.4.

Review effort: Balanced
Findings: 1

Open (1)

• Unrelated version promotion may trigger unintended 3.1.4 release · New