Repository navigation
Make retry/polling intervals overridable vars to speed up tests - #360
Merged
Merged
Conversation
Signed-off-by: Arrobo, Gabriel <gabriel.arrobo@intel.com>
There was a problem hiding this comment.
🟡 Changes recommended
The polling retry test’s shortened fixed wait can cause failures on busy runners.
1 open finding
What changed in this PR
Makes polling and registration timing configurable in tests while preserving production defaults.
Changes:
- Converts retry and polling durations from constants to variables.
- Uses 20ms intervals in selected tests and restores the original values afterward.
| File | Description |
|---|---|
| polling/nf_configuration.go | Makes polling durations overridable. |
| polling/nf_configuration_test.go | Shortens polling intervals in tests. |
| nfregistration/nf_registration.go | Makes registration retry timing overridable. |
| nfregistration/nf_registration_test.go | Shortens and restores the retry interval. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Signed-off-by: Arrobo, Gabriel <gabriel.arrobo@intel.com>
gab-arrobo
force-pushed
the
config-intervals
branch
from
October 15, 2026 20:48
87f3575 to
7730982
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.