Post data save imgRdef#683
Conversation
|
Wasn't the ability to use POST requests for saving rendering settings already introduced in #606? |
|
@sbesson Ah, hmmm - #606 solves the long query string problem for rendering images by removing inactive channels. But it doesn't change the URL length for saving rendering settings. We can update the However, this PR would allow you to save inactive channels. |
#606 reduced the length on the query string for rendering requests but it also enabled some POST requests. Reading more carefully at the changes, the scope was limited the |
|
@sbesson Agreed. But no changes on #606 were made to the saving behaviour / or url length. To enable saving of rendering settings for images with many channels, either we:
The 2nd option gives a nicer experience for users because it will save any changes they've made to inactive channels (which is the current behaviour). |
This is part of a fix for ome/omero-iviewer#545
To avoid issues with long URL request parameters when saving rendering settings, we use the POST
data(instead of the URL).The
saveImgRdefendpoint will now accept both forms.The Preview "webgateway" viewer uses the POST
datato handle the params. This doesn't need any change in construction of the query string or the parsing of the parameters in Django.To test:
datafor POST params - e.g. by using iviewer (without Use POST data for saveImgRdef params omero-iviewer#546), to check that endpoint works with both forms