Greatly improves documentation - #37
Open
jaredperreault-okta wants to merge 8 commits into
Open
Conversation
jaredperreault-okta
marked this pull request as ready for review
August 17, 2026 18:54
Comment on lines
351
to
356
| get isExpired (): boolean { | ||
| if (!this.expirationTime) { | ||
| return false; | ||
| } | ||
| const now = Platform.TimeCoordinator.now(); | ||
| return now.isBefore(this.expirationTime); |
There was a problem hiding this comment.
should this be now.isAfter(this.experiationTime)? or !now.isBefore ?
Contributor
Author
There was a problem hiding this comment.
Maybe I named things awkwardly, but It's comparing if "now" is before X.
There was a problem hiding this comment.
I'm reading it as is token expired? Current time is before expiration time then not expired return false.
FeiChen-okta
approved these changes
Aug 17, 2026
jaredperreault-okta
force-pushed
the
jp-OKTA-1043569
branch
from
August 19, 2026 15:00
5e99c20 to
3fa7a96
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.