Skip to content

[ENG-580] feat: allow clearing facility org/org #3690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jacobjeevan wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

[ENG-580] feat: allow clearing facility org/org #3690

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
97229ea
feat: allow clearing facility_org/org
Jacobjeevan Jun 17, 2026
9dadc15
chore: add else condition
Jacobjeevan Jun 17, 2026
991db98
Merge branch 'develop' into ENG-580-tag-config
vigneshhari Jun 23, 2026
e3f7a7d
chore: allow none default
Jacobjeevan Jun 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions care/emr/resources/tag/config_spec.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,20 +68,24 @@ class TagConfigBaseSpec(EMRResource):


class TagConfigUpdateSpec(TagConfigBaseSpec):
facility_organization: UUID4 | None = None
organization: UUID4 | None = None
facility_organization: UUID4 | None
organization: UUID4 | None
Comment thread
vigneshhari marked this conversation as resolved.
Outdated
Comment thread
vigneshhari marked this conversation as resolved.
Outdated

def perform_extra_deserialization(self, is_update, obj):
if self.organization:
obj.organization = get_object_or_404(
Organization.objects.only("id"), external_id=self.organization
)
else:
obj.organization = None
if self.facility_organization:
obj.facility_organization = get_object_or_404(
FacilityOrganization.objects.only("id"),
external_id=self.facility_organization,
facility=obj.facility,
)
else:
obj.facility_organization = None


class TagConfigWriteSpec(TagConfigBaseSpec):
Expand Down
Loading