Fixes #52 - #119
Merged
Merged
Fixes #52#119
Conversation
Closed
Member
|
in theory newest versions of somef do support self hosted gitlab instances. Please @andriumon review and merge this pr. |
Collaborator
|
Thanks for the contribution! Everything seems fine by my side. Merging it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
RSFC only worked with github.com and gitlab.com. Repositories on self-hosted GitLab instances (e.g. plmlab.math.cnrs.fr, forge.inrae.fr, gitlab.in2p3.fr) failed in several ways.
Changes
src/rsfc/harvesters/github_harvester.py
detect_repo_type()and_is_gitlab_instance(): host-based detection that recognises self-hosted GitLab.src/rsfc/rsfc_checks/rsfc_checks.py
detect_repo_type()instead of a hardcoded github.com/gitlab.com substring check.src/rsfc/utils/rsfc_helpers.py
detect_repo_type(), fix some issues.Testing
Verified end-to-end on gitlab.in2p3.fr, forge.inrae.fr and plmlab.math.cnrs.fr.
Regression tests completed.
Known limitation
Repositories behind bot-protection proxies (e.g. Anubis) cannot be assessed, since the challenge is enforced upstream of GitLab and is not bypassed by an API token.