Skip to content

[FIX] ResPartener: Skip computing existing Peppol Eas/Endpoint - #5238

Open
Tom-Hermann wants to merge 1 commit into
19.0-onboarding-august-malbfrom
19.0-account_peppol-onboarding-compute-identifier-toher
Open

[FIX] ResPartener: Skip computing existing Peppol Eas/Endpoint#5238
Tom-Hermann wants to merge 1 commit into
19.0-onboarding-august-malbfrom
19.0-account_peppol-onboarding-compute-identifier-toher

Conversation

@Tom-Hermann

Copy link
Copy Markdown

Never recompute field "Peppol Eas/Endpoint" of the company if it's registered on Peppol.

Task ID: 6438994

Never recompute field "Peppol Eas/Endpoint" of the company if it's registered on Peppol.

Task ID: 6438994
@robodoo

robodoo commented Aug 11, 2026

Copy link
Copy Markdown

This PR targets the un-managed branch odoo-dev/odoo:19.0-onboarding-august-malb, it needs to be retargeted before it can be merged.

@Tom-Hermann

Copy link
Copy Markdown
Author

I tried writing a comprehensive test using the wizard and mock_request, but nothing really convincing came of it.
Even when I changed the VAT, the test still worked with the old code, so I ran a more “basic” test.

partners_to_recompute = self.browse([partner.id for partner in self if partner._origin not in self])
super(ResPartner, partners_to_recompute)._compute_peppol_endpoint()
partners_to_recompute = self.filtered(
lambda p: not p.peppol_endpoint and p.country_id.code in PEPPOL_LIST

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it's better to check the account_peppol_proxy_state field?

Comment on lines +242 to +244
partners_to_recompute = self.filtered(
lambda p: not p.peppol_eas and p.country_id.code in PEPPOL_LIST
)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants