[ADD] hr_expense: add similar expense detection - #5226
Open
Tom-Hermann wants to merge 1 commit into
Open
Conversation
|
This PR targets the un-managed branch odoo-dev/odoo:19.0-onboarding-august-malb, it needs to be retargeted before it can be merged. |
SaddemAmine
reviewed
Aug 11, 2026
SaddemAmine
left a comment
SaddemAmine
left a comment
There was a problem hiding this comment.
Same comment about the commit tag here btw!
Nice work
Comment on lines
+734
to
+735
|
|
||
|
|
There was a problem hiding this comment.
Extra line break here
Suggested change
| def action_show_similar_expense_ids(self): | ||
| self.ensure_one() | ||
| return self.similar_expense_ids._get_records_action( | ||
| name=_("Similar Expenses to %(other_expense_name)s", other_expense_name=self.name), |
There was a problem hiding this comment.
Starting version 18.0, the translation method is loaded in env
Suggested change
| name=_("Similar Expenses to %(other_expense_name)s", other_expense_name=self.name), | |
| name=self.env._("Similar Expenses to %(other_expense_name)s", other_expense_name=self.name), |
Author
There was a problem hiding this comment.
In the code base, I found a few places where this is still used. Does it no longer work, or is it just depreciate?
I'm just curious.
Comment on lines
+147
to
+149
| duplicate_expense_ids = fields.Many2many(comodel_name='hr.expense', compute='_compute_duplicate_expense_ids') # Used to trigger warnings | ||
| same_receipt_expense_ids = fields.Many2many(comodel_name='hr.expense', compute='_compute_same_receipt_expense_ids') # Used to trigger warnings | ||
| similar_expense_ids = fields.Many2many(comodel_name='hr.expense', compute='_compute_similar_expense_ids') # Used to trigger warnings |
There was a problem hiding this comment.
You already have the field setup for you!
duplicate_expense_ids
| expense.same_receipt_expense_ids = [Command.set(list(same_receipt_ids))] | ||
|
|
||
| @api.depends('product_id', 'date', 'total_amount_currency', 'employee_id') | ||
| def _compute_similar_expense_ids(self): |
Tom-Hermann
force-pushed
the
19.0-hr_expense-onboarding-duplicate-detection-toher
branch
from
August 13, 2026 12:10
0cccb39 to
7fe53c0
Compare
Add a new warning message in the expense form view to alert the user when a similar expense already exists. The similarity is determined by matching the product, date, total amount, and employee.
Tom-Hermann
force-pushed
the
19.0-hr_expense-onboarding-duplicate-detection-toher
branch
from
August 13, 2026 12:11
7fe53c0 to
4d996ce
Compare
SaddemAmine
reviewed
Aug 13, 2026
Comment on lines
+1281
to
+1285
| def action_show_duplicate_expense_ids(self): | ||
| self.ensure_one() | ||
| return self.duplicate_expense_ids._get_records_action( | ||
| name=self.env._("Duplicate Expenses to %(other_expense_name)s", other_expense_name=self.name), | ||
| ) |
There was a problem hiding this comment.
You should subtract self from the recordset you render so you don't show the current record to the user
Rest looks good, good job!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new warning message in the expense form view to alert the user when a similar expense already exists. The similarity is determined by matching the product, date, total amount, and employee.
Task id: 6438999