Fix #2174: Deck editor file association broken#2318
Open
kellyelton wants to merge 1 commit into
Open
Conversation
…o false when launching from file When users double-click on .o8d files, the DeckEditorLauncher was being created with shutdown=true, which caused the application to shut down immediately instead of launching the deck editor. This fix changes the parameter to false so the deck editor can properly open the clicked file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Opening .o8d files by double-clicking them (file association) did not launch the deck editor. The deck editor would silently fail to start.
Root Cause
In , was created with , which caused the launcher to skip and never actually launch the deck editor window.
Fix
Changed to so the deck editor launches normally when opened via file association.
Closes #2174