Skip to content

feat: Sort sets by release date in Deck Editor (optional toggle)#2310

Open
kellyelton wants to merge 1 commit into
masterfrom
feature/sort-sets-by-release-date
Open

feat: Sort sets by release date in Deck Editor (optional toggle)#2310
kellyelton wants to merge 1 commit into
masterfrom
feature/sort-sets-by-release-date

Conversation

@kellyelton

@kellyelton kellyelton commented Mar 28, 2026

Copy link
Copy Markdown
Member

Summary

Implements #2230 — adds an optional Sort Sets by Release checkbox to the Deck Editor card browser.

Per maintainer feedback, this is an opt-in toggle (not default behavior) since older games may not consistently populate the releaseDate property on sets.

Changes

  • Prefs.cs: Added SortSetsByReleaseDate preference (persisted across sessions)
  • GameExtensionMethods.cs: Added SetReleaseDate column to card DataTable
  • SearchControl.xaml: Added Sort Sets by Release checkbox + hidden sort column
  • SearchControl.xaml.cs: Added SortByReleaseDate property and ApplySortOrder method

Behavior

  • Default: Alphabetical by card name (no change)
  • Toggle on: Sorted by set release date (oldest first), then card name
  • Sets without release date sort to the end
  • Preference persists across sessions

Closes #2230

root
feat: Add optional sort-by-release-date for sets in Deck Editor
f23e136 
Implements #2230 - adds a 'Sort Sets by Release' checkbox in the Deck Editor
that allows users to sort the card results by set release date instead of
alphabetically.

Per maintainer feedback, this is an opt-in toggle (not default) since older
games may not consistently populate the releaseDate property on sets.

Changes:
- Prefs.cs: Add SortSetsByReleaseDate preference (persisted across sessions)
- GameExtensionMethods.cs: Add SetReleaseDate column to card DataTable
- SearchControl.xaml: Add 'Sort Sets by Release' checkbox + hidden sort column
- SearchControl.xaml.cs: Add SortByReleaseDate property, ApplySortOrder method
  that sorts DataView by SetReleaseDate ASC then Name ASC
- .gitignore: Exclude octgn-electron/node_modules/
@kellyelton kellyelton added the reviewing PR is currently being reviewed by the automated reviewer label Mar 28, 2026
@kellyelton

kellyelton commented Mar 28, 2026

Copy link
Copy Markdown
Member Author

🤖🧐 Automated Review Started — Running 3-level review (standard, security, requirements).

@kellyelton kellyelton removed the reviewing PR is currently being reviewed by the automated reviewer label Mar 28, 2026
@kellyelton

kellyelton commented Mar 28, 2026

Copy link
Copy Markdown
Member Author

🤖🧐 ✅ Automated Code Review — PASSED

PR: #2310 — feat: Sort sets by release date in Deck Editor (optional toggle)
Issue: #2230 — Sort Sets in Deck Editor by Release Date

Level 1: Standard Code Review ✅
Clean implementation with proper PropertyChanged pattern, good performance caching, and follows existing code patterns.

Level 2: Security Review ✅
No security concerns - pure UI sorting feature with no input handling or authentication changes.

Level 3: Requirements Review ✅
Directly addresses issue #2230 - implements optional sorting by release date as requested, with proper handling of sets without release dates.

All 3 review levels passed. Ready for merge.

Note: Cannot auto-approve as this PR was created by the bot - requires human review for approval.

@kellyelton kellyelton mentioned this pull request Mar 28, 2026
Draft
57 tasks
@kellyelton kellyelton added awaiting-review Awaiting automated review reviewing PR is currently being reviewed by the automated reviewer labels Mar 28, 2026
@kellyelton

kellyelton commented Mar 28, 2026

Copy link
Copy Markdown
Member Author

🤖🧐 Automated Review Started — Running 3-level review (standard, security, requirements).

@kellyelton

kellyelton commented Mar 28, 2026

Copy link
Copy Markdown
Member Author

🤖🧐 ✅ Automated Code Review — PASSED

PR: #2310 — feat: Sort sets by release date in Deck Editor (optional toggle)
Issue: #2230 — Sort Sets in Deck Editor by Release Date

Level 1: Standard Code Review ✅
Clean implementation with proper PropertyChanged pattern, good performance caching, and follows existing code patterns.

Level 2: Security Review ✅
No security concerns - pure UI sorting feature with no input handling or authentication changes.

Level 3: Requirements Review ✅
Directly addresses issue #2230 - implements optional sorting by release date as requested, with proper handling of sets without release dates.

All 3 review levels passed. Ready for merge.

Note: Cannot auto-approve as this PR was created by the bot - requires human review for approval.

@kellyelton kellyelton added reviewing PR is currently being reviewed by the automated reviewer and removed awaiting-review Awaiting automated review reviewing PR is currently being reviewed by the automated reviewer labels Mar 28, 2026
@kellyelton

kellyelton commented Mar 28, 2026

Copy link
Copy Markdown
Member Author

🤖🧐 Automated Review Started — Running 3-level review (standard, security, requirements).

@kellyelton

kellyelton commented Mar 28, 2026

Copy link
Copy Markdown
Member Author

🤖🧐 ✅ Automated Code Review — PASSED

PR: #2310 — feat: Sort sets by release date in Deck Editor (optional toggle)
Issue: #2230 — Sort Sets in Deck Editor by Release Date

Level 1: Standard Code Review ✅
Clean, readable code with proper separation of concerns and clear naming. No logic errors, null reference issues, or security concerns detected.

Level 2: Security Review ✅
No security vulnerabilities found. Code handles only UI data binding and preferences without injection, hardcoded secrets, or other security risks.

Level 3: Requirements Review ✅
Directly addresses issue #2230 - implements optional sorting by release date as requested, with proper handling of sets without release dates.

All 3 review levels passed. Ready for merge.

@kellyelton kellyelton added awaiting-review Awaiting automated review reviewing PR is currently being reviewed by the automated reviewer and removed reviewing PR is currently being reviewed by the automated reviewer labels Mar 28, 2026
@kellyelton

kellyelton commented Mar 28, 2026

Copy link
Copy Markdown
Member Author

🤖🧐 Automated Review Started — Running 3-level review (standard, security, requirements).

@kellyelton

kellyelton commented Mar 28, 2026

Copy link
Copy Markdown
Member Author

🤖🧐 ✅ Automated Code Review — PASSED

PR: #2310 — feat: Sort sets by release date in Deck Editor (optional toggle)
Issue: #2230 — Sort Sets in Deck Editor by Release Date

Level 1: Standard Code Review ✅
Clean implementation with proper data structure handling, UI controls, and sorting logic.

Level 2: Security Review ✅
No security concerns - purely UI/data manipulation with no external inputs.

Level 3: Requirements Review ✅
Directly addresses issue #2230 - optional release date sorting with proper handling of missing dates.

All 3 review levels passed. Ready for merge.

@kellyelton kellyelton removed awaiting-review Awaiting automated review reviewing PR is currently being reviewed by the automated reviewer labels Mar 28, 2026
@kellyelton kellyelton mentioned this pull request Apr 2, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Sort Sets in Deck Editor by Release Date

1 participant

@kellyelton