Skip to content

Fix #2028: Suppress false unsaved changes prompt when loading a deck #2297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kellyelton wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix #2028: Suppress false unsaved changes prompt when loading a deck #2297

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 22 additions & 11 deletions octgnFX/Octgn.JodsEngine/DeckBuilder/DeckBuilderWindow.xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ public partial class DeckBuilderWindow : INotifyPropertyChanged, IDeckBuilderPlu
private Game _game;
private ObservableSection _section;
private bool _unsaved;
private bool _isLoading;
private string selection = null;
private Guid set_id;

Expand Down Expand Up @@ -102,20 +103,29 @@ private void SetupAndLoadDeck(IDeck deck)
{
if (deck != null)
{
if (deck is MetaDeck)
{
this._deckFilename = (deck as MetaDeck).Path;
}
var g = GameManager.Get().Games.FirstOrDefault(x => x.Id == deck.GameId);
if (g != null)
_isLoading = true;
try
{
Game = g;
Deck = deck.AsObservable();
SleeveImage = deck.Sleeve.GetImage();
if (deck is MetaDeck)
{
this._deckFilename = (deck as MetaDeck).Path;
}
var g = GameManager.Get().Games.FirstOrDefault(x => x.Id == deck.GameId);
if (g != null)
{
Game = g;
Deck = deck.AsObservable();
SleeveImage = deck.Sleeve.GetImage();
}
else
{
TopMostMessageBox.Show($"The game required by the deck is not installed. Please install it first.", "Error", MessageBoxButton.OK, MessageBoxImage.Error);
}
}
else
finally
{
TopMostMessageBox.Show($"The game required by the deck is not installed. Please install it first.", "Error", MessageBoxButton.OK, MessageBoxImage.Error);
_isLoading = false;
_unsaved = false;
}
}
}
Expand Down Expand Up @@ -1314,6 +1324,7 @@ private void LoadSearchClick(object sender, RoutedEventArgs e)

private void NotesTextChanged(object sender, TextChangedEventArgs e)
{
if (_isLoading) return;
_unsaved = true;
Deck.Notes = (sender as TextBox).Text;
}
Expand Down