Skip to content

data-encoding: disable tests#30106

Merged
mseri merged 1 commit into
ocaml:masterfrom
mseri:data-encoding
Jun 23, 2026
Merged

data-encoding: disable tests#30106
mseri merged 1 commit into
ocaml:masterfrom
mseri:data-encoding

Conversation

@mseri

@mseri mseri commented Jun 23, 2026

Copy link
Copy Markdown
Member

Contains a brittle test on json generation that fails all the time, unnecessarily polluting the CI output

 File "test/pbt/dune", line 3, characters 43-58:
 3 |    test_json_stream_sizes test_classifiers test_sub_string
                                                ^^^^^^^^^^^^^^^
 (cd _build/default/test/pbt && ./test_sub_string.exe)
 Fatal error: exception File "test/pbt/test_sub_string.ml", line 35, characters 2-8: Assertion failed
 (cd _build/default/test/pbt && ./test_json_stream_sizes.exe)
 blitting with a lot of string boundaries: PASS

 string-seq with a lot of string boundaries: PASS

 File "test/pbt/dune", line 4, characters 3-27:
 4 |    json_roundtrip_in_binary)
        ^^^^^^^^^^^^^^^^^^^^^^^^
 (cd _build/default/test/pbt && ./json_roundtrip_in_binary.exe)
 json_json_roundtrip: FAIL

 When given the input:

     <float>

 the test threw an exception:

     File "test/pbt/json_roundtrip_in_binary.ml", line 92, characters 2-8: Assertion failed
     Raised at Dune__exe__Json_roundtrip_in_binary.test_json in file "test/pbt/json_roundtrip_in_binary.ml", line 92, characters 2-17
     Called from Crowbar.gen_apply.go.(fun) in file "src/crowbar.ml", line 352, characters 16-19

 json_binary(bson)_roundtrip: FAIL

or

File "test/pbt/dune", lines 83-87, characters 0-111:
 83 | (rule
 84 |  (alias runtest)
 85 |  (package data-encoding)
 86 |  (action
 87 |   (run node %{dep:./json_roundtrip_in_binary.bc.js})))
 (cd _build/default/test/pbt && /usr/bin/node json_roundtrip_in_binary.bc.js)
 json_json_roundtrip: FAIL

 When given the input:

     <float>

 the test threw an exception:

     File "test/pbt/json_roundtrip_in_binary.ml", line 92, characters 2-8: Assertion failed

 json_binary(bson)_roundtrip: FAIL

 When given the input:

     <float>

 the test threw an exception:

     File "test/pbt/json_roundtrip_in_binary.ml", line 116, characters 28-34: Assertion failed

depending on the version.

See e.g. https://opam.ci.ocaml.org/github/ocaml/opam-repository/commit/72f51de94a07b75e147fd7a49002aebddd7c8ca8

Last seen #30088

Contains a brittle test on json generation that fails all the time, unnecessarily polluting the CI output

```
 File "test/pbt/dune", line 3, characters 43-58:
 3 |    test_json_stream_sizes test_classifiers test_sub_string
                                                ^^^^^^^^^^^^^^^
 (cd _build/default/test/pbt && ./test_sub_string.exe)
 Fatal error: exception File "test/pbt/test_sub_string.ml", line 35, characters 2-8: Assertion failed
 (cd _build/default/test/pbt && ./test_json_stream_sizes.exe)
 blitting with a lot of string boundaries: PASS

 string-seq with a lot of string boundaries: PASS

 File "test/pbt/dune", line 4, characters 3-27:
 4 |    json_roundtrip_in_binary)
        ^^^^^^^^^^^^^^^^^^^^^^^^
 (cd _build/default/test/pbt && ./json_roundtrip_in_binary.exe)
 json_json_roundtrip: FAIL

 When given the input:

     <float>

 the test threw an exception:

     File "test/pbt/json_roundtrip_in_binary.ml", line 92, characters 2-8: Assertion failed
     Raised at Dune__exe__Json_roundtrip_in_binary.test_json in file "test/pbt/json_roundtrip_in_binary.ml", line 92, characters 2-17
     Called from Crowbar.gen_apply.go.(fun) in file "src/crowbar.ml", line 352, characters 16-19

 json_binary(bson)_roundtrip: FAIL
```
or
```
File "test/pbt/dune", lines 83-87, characters 0-111:
 83 | (rule
 84 |  (alias runtest)
 85 |  (package data-encoding)
 86 |  (action
 87 |   (run node %{dep:./json_roundtrip_in_binary.bc.js})))
 (cd _build/default/test/pbt && /usr/bin/node json_roundtrip_in_binary.bc.js)
 json_json_roundtrip: FAIL

 When given the input:

     <float>

 the test threw an exception:

     File "test/pbt/json_roundtrip_in_binary.ml", line 92, characters 2-8: Assertion failed

 json_binary(bson)_roundtrip: FAIL

 When given the input:

     <float>

 the test threw an exception:

     File "test/pbt/json_roundtrip_in_binary.ml", line 116, characters 28-34: Assertion failed
```
depending on the version.

See e.g. https://opam.ci.ocaml.org/github/ocaml/opam-repository/commit/72f51de94a07b75e147fd7a49002aebddd7c8ca8
Signed-off-by: Marcello Seri <marcello.seri@gmail.com>
@mseri
mseri merged commit e0d2b0f into ocaml:master Jun 23, 2026
4 of 5 checks passed
@mseri
mseri deleted the data-encoding branch June 23, 2026 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant