fix(github): make the branch picker usable on repos with 100+ branches - #884
Open
abdelrhmanehab10 wants to merge 1 commit into
Open
abdelrhmanehab10 wants to merge 1 commit into
abdelrhmanehab10 wants to merge 1 commit into
Conversation
Load the first branch page during preparation and fetch later pages as the picker scrolls. Preserve current main behavior while keeping the selected branch available.
abdelrhmanehab10
force-pushed
the
fix/870-branch-selector-pagination
branch
from
September 13, 2026 19:23
f5845ed to
c9c7fbf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mainbranch could be missing entirely and unselectable.listBranchesnow fetches lazily by page (page/hasMore) instead of truncating, and downstream callers (project creation/validation, deploy prep) were updated for the new paginated contract.CustomSelect) now actually scrolls — its inner option list previously never resolved a constrained height (amax-h-fullpercentage-height quirk), so it just silently clipped past the first screenful with no visible scrollbar, independent of the backend truncation bug.Test plan
apps/api/src/modules/github/github.branches.test.tscovers the new page-basedlistBranchescontract (single page,hasMoreon a full page).kanbn/kanrepo (158 branches,mainoriginally sorted ~53 branches past the old 100-item cutoff):clientHeightclamped vs.scrollHeight), confirmed via DOM measurement and screenshots.GET /branches?page=2request and all 158 branches load.fix/kan→ 8 matches).