fix(api): mask build arguments and preserve secrets on round trips - #864
Open
AbdullahM07 wants to merge 1 commit into
Open
AbdullahM07 wants to merge 1 commit into
AbdullahM07 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Mask build-argument values in service, scan, drift, build-status and deployment responses, including retained deployment history. Restore masked values on writes so editing a service or redeploying cannot replace a secret with the mask sentinel.
Motivation
Deployment snapshots and service rows masked
environmentbut returnedbuildArgsverbatim. Older releases consequently exposed earlier secret values after rotation. Output masking also needs write-path recovery to preserve working builds and rollback snapshots.Related issue
Fixes #854
Changes
Fingerprints cover stored literals. Inherited and interpolated args are excluded because their effective values depend on the build environment; fingerprints do not attest running-container state. These semantics and whole-map build-arg replacement are documented in the Services API guide.
Verification
bun run test -- --filter=!openship -- --maxWorkers=2: all six workspace tasks passed; API: 478 files, 5642 passed / 3 skipped.bun run --cwd apps/api lint: passed.bun run formatin an isolated checkout and retained only formatting within this change.Checklist