fix(dashboard): keep GitHub device sign-in visible until completion - #862
Open
AbdullahM07 wants to merge 1 commit into
Open
AbdullahM07 wants to merge 1 commit into
AbdullahM07 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keep the GitHub device code and verification link visible until that grant completes, then refresh Settings to show the newly connected identity.
Motivation
Settings hid the pending action whenever any GitHub source was connected. The shared provider also discarded it based on an existing App connection or a stale CLI identity. A valid device-code response could therefore disappear immediately, and successful polling did not update Settings' separate status snapshot.
Related issue
Fixes #851
Changes
Verification
bun run --cwd apps/dashboard test --maxWorkers=2: 114 files, 1186 tests passed.bun run --cwd apps/dashboard lint: passed.bun run formatin an isolated checkout and retained only formatting within this change.Checklist