fix(dashboard): rescan deployment configuration when branches change - #855
Open
AbdullahM07 wants to merge 1 commit into
Open
AbdullahM07 wants to merge 1 commit into
AbdullahM07 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changing the branch in the deploy wizard now scans the selected ref and applies the branch and its detected configuration together. A branch without a recognizable framework opens the manual picker instead of retaining the previous branch's Compose detection.
Motivation
The selector only updated
config.branch. Repository initialization also preferred the saved branch and build defaults over an explicit branch override, so deployments could use a different tree from the one described by the UI.Related issue
Fixes #852
Changes
Verification
The initial full run hit an existing CLI port-test timeout: this machine already uses port 3001, so the resolver waits six seconds against Vitest's five-second default. The entire CLI suite passes with the timeout shown above; no CLI code or tests were changed.
Regression proof: all eight original branch-switch cases failed against
upstream/main; the final suite passes all nine cases, including domain preservation. Headless Chromium checks of loading, error, and manual-selection states passed at 1280px and 390px with no horizontal overflow.Checklist