Describe the bug
Using a Pipenv environment, I get a ModuleNotFoundError for Levenshtein and nltk when trying to run python -m jiant.scripts.benchmarks.benchmark_submission_formatter.
To Reproduce
- Jiant v2.2.0
- Windows 11, Pipenv environment
- Config artifact: N/A
Expected behavior
python -m jiant.scripts.benchmarks.benchmark_submission_formatter should run without any ModuleNotFoundError errors.
pipenv install -r requirements.txt should install all the dependencies required for this project. However, in a Pipenv environment, the Levenshtein and nltk libraries are not included, as the requirements.txt file does not include Levenshtein and nltk.
As a result, running python -m jiant.scripts.benchmarks.benchmark_submission_formatter returns a ModuleNotFoundError for both dependencies.
While separately installing both Levenshtein and nltk is a quick fix, including both dependencies in the requirements.txt file in the root directory would solve these import errors when a user runs jiant in a new virtual environment where Levenshtein and nltk are not yet installed.
Additional context
Proposed additions to requirements.txt:
nltk==3.8.1
Levenshtein==0.23.0
Please not that I have not yet run tests using these versions, and that further review may be needed to ensure that all unit tests pass using these specific versions.
I'm happy to create a new branch and to add these two dependencies to the requirements* files, though please let me know which next steps would be the most ideal.
Describe the bug
Using a Pipenv environment, I get a
ModuleNotFoundErrorforLevenshteinandnltkwhen trying to runpython -m jiant.scripts.benchmarks.benchmark_submission_formatter.To Reproduce
Expected behavior
python -m jiant.scripts.benchmarks.benchmark_submission_formattershould run without anyModuleNotFoundErrorerrors.pipenv install -r requirements.txtshould install all the dependencies required for this project. However, in a Pipenv environment, theLevenshteinandnltklibraries are not included, as therequirements.txtfile does not includeLevenshteinandnltk.As a result, running
python -m jiant.scripts.benchmarks.benchmark_submission_formatterreturns aModuleNotFoundErrorfor both dependencies.While separately installing both
Levenshteinandnltkis a quick fix, including both dependencies in therequirements.txtfile in the root directory would solve these import errors when a user runsjiantin a new virtual environment whereLevenshteinandnltkare not yet installed.Additional context
Proposed additions to
requirements.txt:Please not that I have not yet run tests using these versions, and that further review may be needed to ensure that all unit tests pass using these specific versions.
I'm happy to create a new branch and to add these two dependencies to the
requirements*files, though please let me know which next steps would be the most ideal.