Fix virtual buffer creation when object IDs are None#20440
Open
cary-rowen wants to merge 2 commits into
Open
Conversation
Contributor
Author
|
Hi @prakashgomathi1-ui, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #20356
Summary of the issue:
In Foxit PDF Editor, NVDA could fail to create a virtual buffer for PDF content. When this happened, arrow keys scrolled the PDF instead of reading it.
Some virtual buffer backends can return
Nonefor part of an object identifier. This used to be accepted as0by ctypes, but the typed 64-bit VBuf calls now rejectNonefor integer arguments.Description of user facing changes:
PDF content in Foxit PDF Editor can be read with browse mode again when an object identifier contains
None.Description of developer facing changes:
Virtual buffer object identifiers are normalized before being passed to VBuf helper functions.
Description of development approach:
Added a small helper to convert
Nonevalues in virtual buffer identifiers to0.This is handled in the shared virtual buffer code so buffer creation and related object lookup paths use the same behavior.
Testing strategy:
Manual testing.
Known issues with pull request:
None known.
Code Review Checklist: