configuration profiles dialog. Added context menu and shortcuts for profiles#20435
Open
amirmahdifard wants to merge 1 commit into
Open
configuration profiles dialog. Added context menu and shortcuts for profiles#20435amirmahdifard wants to merge 1 commit into
amirmahdifard wants to merge 1 commit into
Conversation
…iles list of configuration profiles dialog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
fixes #18169
Summary of the issue:
The configuration dialog was not supporting a context menu and shortcuts. When I Opened the issue, feedback suggestions came from users regarding the shortcuts (f2 to rename), (delete to delete) useful shortcuts
Description of user facing changes:
A context menu has been added to the profiles list of configuration profiles dialog and also shortcuts, focusing a profile, press f2 to rename the profile, and delete to delete the profile
Description of developer facing changes:
none
Description of development approach:
Added a on context menu method contaning actions and statements regarding taking care of profile actions are not available for normal configuration profile, and also added a charhook method, and bound them to the profiles list.
Testing strategy:
manual testing. Tested The configuration profiles dialog with the folowing. Tested that the context menu works, the actions inside it are all correctly working and bound to the existing methods. Same for onCharhook. Made sure that shortcuts are correctly working and bound to the existing rename and delete profiles method.
Known issues with pull request:
none
Code Review Checklist: