Added support for the myBraille family of Help Tech Braille displays.#20426
Open
FelixGruetzmacher wants to merge 1 commit into
Open
Added support for the myBraille family of Help Tech Braille displays.#20426FelixGruetzmacher wants to merge 1 commit into
FelixGruetzmacher wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Not applicable.
Summary of the issue:
The Help Tech myBraille models should be supported.
Description of user facing changes:
The myBraille family of Help Tech Braille devices are now fully supported via USB and Bluetooth, including automatic detection.
Description of developer facing changes:
The driver was changed accordingly. No API changes.
Description of development approach:
The device ID bytes for the four new models were added. A common superclass for them was introduced and then specialized into four model-specific classes. A common factory was considered but dismissed as the features of the different models may diverge in the future.
Testing strategy:
Functionality was tested with demo units of the different myBraille models.
Known issues with pull request:
None.
Code Review Checklist: