Skip to content

Speech dictionaries dialog. Added a context menu to the dicts list#20424

Open
amirmahdifard wants to merge 4 commits into
nvaccess:masterfrom
amirmahdifard:Speech_dictionaries_context_menu
Open

Speech dictionaries dialog. Added a context menu to the dicts list#20424
amirmahdifard wants to merge 4 commits into
nvaccess:masterfrom
amirmahdifard:Speech_dictionaries_context_menu

Conversation

@amirmahdifard

@amirmahdifard amirmahdifard commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Link to issue number:

fixes #20420

Summary of the issue:

the Speech dictionaries list item actions could only be managed by the buttons. Like many other windows dialogs, Also added context menu to this list, so users can use both, whatever they are comftable with

Description of user facing changes:

A context menu has been added to the entries list of the Speech dictionaries dialog and can be opened that has edit, and remove options in it. No other interface changes.

Description of developer facing changes:

none

Description of development approach:

Added a context menu method, Added translater comments, and bound the context menu evt to dict list

Testing strategy:

opened Speech dictionaries dialog, Added edited and removed entries, made sure that both buttons and context menu are functional as before, And also made sure other used keys will continue to act as before and nothing extra is touched and changed

Known issues with pull request:

none

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@amirmahdifard amirmahdifard requested review from a team as code owners June 30, 2026 07:55
Comment thread source/gui/speechDict.py Outdated
Comment thread user_docs/en/changes.md Outdated

@cary-rowen cary-rowen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's just a minor issue with the documentation.

@amirmahdifard amirmahdifard force-pushed the Speech_dictionaries_context_menu branch from 83ae934 to 0b2dade Compare July 1, 2026 07:38
Comment thread user_docs/en/userGuide.md Outdated
Comment thread user_docs/en/changes.md Outdated
amirmahdifard and others added 2 commits July 2, 2026 15:28
Co-authored-by: Cyrille Bougot <cyrille.bougot2@laposte.net>
…le, And updated the correct spelling changelog entri
@amirmahdifard

amirmahdifard commented Jul 2, 2026

Copy link
Copy Markdown
Contributor Author

@cary-rowen done! thanks! I very liked your suggestion. In addon store, we are forced to open context menu with every action, but here, when we can edit an existing rule, it's the best place for it. I Also implemented delete key shortcut to remove a rule to also be consistent with other dialogs I've Added context menu and shortcut support for. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Speech dictionaries dialog. Add context menu on the dicts entries list

4 participants