Speech dictionaries dialog. Added a context menu to the dicts list#20424
Open
amirmahdifard wants to merge 4 commits into
Open
Speech dictionaries dialog. Added a context menu to the dicts list#20424amirmahdifard wants to merge 4 commits into
amirmahdifard wants to merge 4 commits into
Conversation
CyrilleB79
reviewed
Jun 30, 2026
cary-rowen
reviewed
Jul 1, 2026
cary-rowen
reviewed
Jul 1, 2026
cary-rowen
left a comment
Contributor
There was a problem hiding this comment.
It's just a minor issue with the documentation.
83ae934 to
0b2dade
Compare
CyrilleB79
reviewed
Jul 2, 2026
CyrilleB79
reviewed
Jul 2, 2026
Co-authored-by: Cyrille Bougot <cyrille.bougot2@laposte.net>
…le, And updated the correct spelling changelog entri
Contributor
Author
|
@cary-rowen done! thanks! I very liked your suggestion. In addon store, we are forced to open context menu with every action, but here, when we can edit an existing rule, it's the best place for it. I Also implemented delete key shortcut to remove a rule to also be consistent with other dialogs I've Added context menu and shortcut support for. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
fixes #20420
Summary of the issue:
the Speech dictionaries list item actions could only be managed by the buttons. Like many other windows dialogs, Also added context menu to this list, so users can use both, whatever they are comftable with
Description of user facing changes:
A context menu has been added to the entries list of the Speech dictionaries dialog and can be opened that has edit, and remove options in it. No other interface changes.
Description of developer facing changes:
none
Description of development approach:
Added a context menu method, Added translater comments, and bound the context menu evt to dict list
Testing strategy:
opened Speech dictionaries dialog, Added edited and removed entries, made sure that both buttons and context menu are functional as before, And also made sure other used keys will continue to act as before and nothing extra is touched and changed
Known issues with pull request:
none
Code Review Checklist: