refactor(menu): slice the list page with get instead of indexing - #1180
Open
kronberger-droid wants to merge 1 commit into
Open
refactor(menu): slice the list page with get instead of indexing#1180kronberger-droid wants to merge 1 commit into
kronberger-droid wants to merge 1 commit into
Conversation
`end` is clamped to the values but `start` is summed from the recorded page sizes; if those ever outrun `values` (pages built for an earlier, longer result) `start > end` and the range panics mid-paint. `get` shows the empty menu, NO RECORDS FOUND, instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The page slice in
ListMenu::get_valuesclampsendto the values but sumsstartfrom the recorded page sizes.If those ever outrun
values(pages built for an earlier, longer result),start > endand the range indexing panics mid-paint.get(start..end).unwrap_or(&[])shows the empty menu, NO RECORDS FOUND, instead.No behaviour change while the page sizes are consistent, no public API change.