refactor(menu): read the picked example through and_then instead of expect - #1174
Open
kronberger-droid wants to merge 1 commit into
Open
Conversation
…xpect `example_index` is only ever set inside `examples` and is reset whenever the list is rebuilt, so the `expect` held. `and_then` asks the one question `replace_in_buffer` has, is there a picked example, without a way to panic; if the invariant ever slips the suggestion goes in unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DescriptionMenu::replace_in_bufferunwrappedexample_indexand thenexamples.get(..)with anexpect.The index is only ever set inside
examplesand reset when the list is rebuilt, so it held, butand_thenasks the one question the fn has, is there a picked example, without a way to panic.If the invariant ever slips the suggestion goes in unchanged instead of aborting on Enter.
No behaviour change, no public API change.