Fix vi replace with v - #1169
Open
catlover-bot wants to merge 1 commit into
Open
Conversation
catlover-bot
marked this pull request as ready for review
August 18, 2026 16:15
Collaborator
|
Looks good. Some things I would maybe do before we land this:
Thanks for handling this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix vi normal-mode
r<char>replacement when the replacement character isv.Before
After pressing
rin vi normal mode, pressingventered visual mode instead of completing the pending replace command.The special-case handling for
vran before the pending multi-key command could consume it.After
venters visual mode only when there is no pending vi command. Whenris already pending,vis consumed as the replacement character and producesReplaceChar('v').A regression test covers the
rvsequence while preserving the existing standalonevbehavior.Additional notes
Fixes #1159.
Validation:
cargo test edit_mode::vi:: -- --nocapture— 148 passedcargo fmt --all -- --checkcargo clippy --locked --all-targets --all-featurescargo test --all --all-features -- --test-threads=1— 1525 passed, 1 ignored; 30 doctests passedgit diff --check