refactor: make three invariant re-checks structural - #1168
Open
kronberger-droid wants to merge 4 commits into
Open
refactor: make three invariant re-checks structural#1168kronberger-droid wants to merge 4 commits into
kronberger-droid wants to merge 4 commits into
Conversation
`longest_match` is taken from `line`, so the two halves always exist; `split_once` says so in the type where `splitn(2)` plus `[0]`/`[1]` did not.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three small sites from the panic-surface sweep, none a reachable panic in practice,
each a guard the type did not carry:
locate_word:WordKind::Unicodewas handled by an early return above amatchthat then needed anunreachable!arm for it.The return now lives in the match, so three kinds are three arms.
end_of_lineandcoerce_crlf: both readbytes[i - 1] == b'\r'under ani > 0guard.The guard stays for the subtraction; the read goes through
get().No public API change, no behaviour change.