chore: drop the idle_callback feature flag - #1158
Open
kronberger-droid wants to merge 1 commit into
Open
Conversation
It gated an `Option` field and two `is_some` checks, no dependency, and was not in the CI matrix. `with_idle_callback` is now always available; `--features idle_callback` becomes a no-op cargo warning.
Contributor
|
I'm definitely good with less features. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
idle_callbackgated anOption<Box<dyn FnMut>>field onReedline, twois_somechecks and thewith_idle_callbackbuilder.No dependency behind it, not in the CI matrix (only
--all-featurestouched it), no example, no nushell use.A flag that toggles a public method is a papercut for docs.rs readers and buys nothing measurable, thus the gate is gone and
with_idle_callbackis always available.Public API:
with_idle_callbackno longer needs a feature. Passing--features idle_callbacknow yields cargo's unknown-feature warning and nothing else.No behavior change: polling only starts once a callback is set, same as before.