feat(history): let callers construct HistorySessionId - #1157
Open
kronberger-droid wants to merge 1 commit into
Open
feat(history): let callers construct HistorySessionId#1157kronberger-droid wants to merge 1 commit into
kronberger-droid wants to merge 1 commit into
Conversation
nushell's history import has to invent session ids and could not, since `new` was `pub(crate)`. The field is `pub` like `HistoryItemId`.
kronberger-droid
force-pushed
the
fix/history-session-id-pub
branch
from
August 17, 2026 11:30
585493f to
d97ab82
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HistorySessionId::newwaspub(crate), so downstream code that needs to mint a session id (nushell'shistory import, which carries a "reedline doesn't let you create session IDs" comment for exactly this) had no way to.newis nowpub. The rawi64field goes private rather thanpub, since the id already reads back throughDisplayand serde and nothing outside the crate touches it.Public API: adds
HistorySessionId::new. The field visibility change is not observable outside the crate (it waspub(crate)).