fix: return detailed vertex status message when unhealthy

[AyushSrivastava1818]

What this PR does / why we need it

When a vertex is unhealthy, CheckVertexStatus currently returns a generic message:

Vertex "<name>" is not healthy

This hides the more detailed diagnostic information already available in vertex.Status.Message.

This PR updates CheckVertexStatus to return vertex.Status.Message when it is available, while preserving the existing generic fallback message when no detailed status message exists.

Additionally, a unit test has been added to verify the new behavior without changing the existing fallback behavior.

Related issues

Fixes #3496

Testing

• Added a unit test covering the detailed status message behavior.
• Existing fallback behavior remains covered by the current tests.
• Ran:

gofmt -w pkg/reconciler/util.go pkg/reconciler/util_test.go
go test ./pkg/reconciler/...

[adarsh0728]

can you fix DCO check? (signed commit)

[vaibhavtiwari33]

Suggested change

	return false, "Unavailable", vertex.Status.Message
	return false, "Unavailable", `Vertex "` + vertex.Spec.Name + `" error: ` + vertex.Status.Message

[vaibhavtiwari33]

Can you please also provide example of how this message appears in status from a running pipeline that is failing.

[AyushSrivastava1818]

Thanks for the review!

I've updated the returned message to include the vertex name and pushed the changes.

Regarding the example, I don't currently have a failing pipeline available to capture an actual vertex.Status.Message. The intent of this change is to surface the existing vertex.Status.Message from the vertex status instead of returning only the generic Vertex "<name>" is not healthy message.

If needed, I can try to reproduce a failing pipeline and share an actual status output.

[vaibhavtiwari33]

If needed, I can try to reproduce a failing pipeline and share an actual status output.

Yes pls

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.07%. Comparing base (f834af7) to head (55f7712).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3502      +/-   ##
==========================================
- Coverage   83.08%   83.07%   -0.01%     
==========================================
  Files         310      310              
  Lines       81395    81397       +2     
==========================================
  Hits        67624    67624              
- Misses      13174    13176       +2     
  Partials      597      597              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[AyushSrivastava1818]

Thanks! I'm setting up a local Numaflow environment to reproduce a failing pipeline and capture an actual vertex.Status.Message. I don't have a Kubernetes cluster configured on this machine yet, so it will take me a bit of time to set it up.

I'll update this PR with a real status output as soon as I have it. Thanks for your patience!