Skip to content

Dual-Axis support? What about fsync mode context? #1

Open

Description

@Montana

Hey @nubskr,

I was thinking it'd be great to have Dual-Axis support for Walrus. For example maybe putting something under

# Set up better Y-axis formatting

That looks something similar to this:

def create_dual_axis_plot(self):
    self.fig, self.ax1 = plt.subplots(1, 1, figsize=(12, 6))
    self.ax2 = self.ax1.twinx()
    
    self.ax1.set_ylabel('Writes/sec', color='b')
    self.ax1.tick_params(axis='y', labelcolor='b')
    
    self.ax2.set_ylabel('MB/sec', color='r')
    self.ax2.tick_params(axis='y', labelcolor='r')

I also realized whilst using Walrus, I didn't see any fsync mode context. So essentially the benchmarks can run with different fsync settings, but the visualization doesn't show which mode was used, any plan when updates/versions are pushed out this may be a feature?

Thanks for Walrus @nubskr, been super helpful to me for this project I'm working on.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions