Feature/tls cert protos file 3021 - #3209
Open
kalindafab wants to merge 4 commits into
Open
Conversation
|
IvanNardi
reviewed
Jul 29, 2026
| nDPI_TestApp@tls_cert:"CN=nDPI_TestCert" | ||
|
|
||
| # Match by Organization | ||
| nDPI_TestOrg@tls_cert:"O=nDPI_Test_Org" |
Collaborator
There was a problem hiding this comment.
As reported by @lucaderi here (#3099 (comment)) we want to match hash certificate.
So the rule (in protos.txt file) must be something like:
tls_cert_hash:da:39:a3:ee:5e:6b:4b:0d:32:55:bf:ef:95:60:18:90:af:d8:07:09@ProtoName.
No PEM/key stuff
Collaborator
|
@kalindafab, first of all, please rebase |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please sign (check) the below before submitting the Pull Request:
Link to the related issue:Addresses issue #3021
Describe changes:Added support of dynamic TLS certificate hash matching by implementing data structure to store rules, extending the protocol parser to recognize @tls_cert_hash syntax, and adding hash comparison logic in TLS detection
@lucaderi seeking your guidance on why the hash matching logic isn't detecting the custom protocol.