Add embedded_hal::serial implementation for uarte (continuation)#343

Merged

bors[bot] merged 21 commits into

nrf-rs:masterfrom

hargoniX:uarte-embedded-serial

Aug 12, 2021

Commits on Aug 12, 2021

Add embedded_hal::serial implementation for uarte

lulf
authored and
hargoniX
committed
Pass TX and RX buffers to split() to ensure move of UartTx and UartRx does not affect memory location for DMA.

lulf
authored and
hargoniX
committed
Check that buffers are in RAM

lulf
authored and
hargoniX
committed
Implement Drop trait to ensure DMA is stopped

lulf
authored and
hargoniX
committed
Require DMA buffers to have static lifetime

lulf
authored and
hargoniX
committed
Ensure write pointer is reset

lulf
authored and
hargoniX
committed
Avoid initiating transfer if no bytes have been written

lulf
authored and
hargoniX
committed
Fix conversion

lulf
authored and
hargoniX
committed
Address review comments

lulf
authored and
hargoniX
committed
Update nrf-hal-common/src/uarte.rs

authored and
hargoniX
committed
Move into parent module

lulf
authored and
hargoniX
committed
Remove unneeded import

lulf
authored and
hargoniX
committed
Update nrf-hal-common/src/uarte.rs

authored and
hargoniX
committed
Call flush if write buffer is full

lulf
authored and
hargoniX
committed
Restrict serial API to read only 1 byte at a time to avoid DMA issues.

lulf
authored and
hargoniX
committed
Simplify by passing slice only

lulf
authored and
hargoniX
committed
Add comment

lulf
authored and
hargoniX
committed
Require a slice of size 1 for rx_buf

lulf
authored and
hargoniX
committed
Consistent buffer length check behavior

lulf
authored and
hargoniX
committed
Add some docs and restart tx/rxstarted on UARTE drop()
hargoniX
committed
Fix uarte write
hargoniX
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add embedded_hal::serial implementation for uarte (continuation)#343

Add embedded_hal::serial implementation for uarte (continuation)#343
bors[bot] merged 21 commits into
nrf-rs:masterfrom
hargoniX:uarte-embedded-serial

Commits on Aug 12, 2021

Add embedded_hal::serial implementation for uarte

Pass TX and RX buffers to split() to ensure move of UartTx and UartRx does not affect memory location for DMA.

Check that buffers are in RAM

Implement Drop trait to ensure DMA is stopped

Require DMA buffers to have static lifetime

Ensure write pointer is reset

Avoid initiating transfer if no bytes have been written

Fix conversion

Address review comments

Update nrf-hal-common/src/uarte.rs

Move into parent module

Remove unneeded import

Update nrf-hal-common/src/uarte.rs

Call flush if write buffer is full

Restrict serial API to read only 1 byte at a time to avoid DMA issues.

Simplify by passing slice only

Add comment

Require a slice of size 1 for rx_buf

Consistent buffer length check behavior

Add some docs and restart tx/rxstarted on UARTE drop()

Fix uarte write