Skip to content

fix(i18n): update Japanese translations#2980

Open
shuuji3 wants to merge 2 commits into
mainfrom
shuuji3/fix/update-japanese
Open

fix(i18n): update Japanese translations#2980
shuuji3 wants to merge 2 commits into
mainfrom
shuuji3/fix/update-japanese

Conversation

@shuuji3

@shuuji3 shuuji3 commented Jul 1, 2026

Copy link
Copy Markdown
Member

🔗 Linked issue

N/A

🧭 Context

  • Newly added several new keys.

📚 Description

  • Add missing Japanese translations.

@vercel

vercel Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Jul 1, 2026 1:30pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Jul 1, 2026 1:30pm
npmx-lunaria Ignored Ignored Jul 1, 2026 1:30pm

Request Review

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
i18n/locales/ja-JP.json Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@coderabbitai

coderabbitai Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: c1c9f35b-3f1c-4798-9d19-5edfc5822d8d

📥 Commits

Reviewing files that changed from the base of the PR and between 1880374 and e67354b.

📒 Files selected for processing (1)
  • i18n/locales/ja-JP.json

📝 Walkthrough

Summary by CodeRabbit

  • New Features
    • Expanded Japanese translations for footer, command palette shortcuts, and the About page sponsors section.
    • Added clearer sponsor labels, including tier names for gold and silver sponsors.

Walkthrough

Updated the Japanese (ja-JP) locale JSON file, adding a sponsored_by footer string, a keyboard_shortcuts object with navigation/select/close labels in the command palette section, and restructured About page sponsor strings with gold and silver tier labels.

Changes

Japanese locale updates

Layer / File(s) Summary
Footer, shortcut, and sponsor tier strings
i18n/locales/ja-JP.json
Adds a sponsored_by footer template alongside the existing "other" label, introduces a keyboard_shortcuts object with navigate/select/close shortcut labels in the command palette section, and expands the About page sponsors area with a title plus gold and silver tier labels.

Possibly related PRs

  • npmx-dev/npmx.dev#2745: Both PRs modify i18n/locales/ja-JP.json to update command-palette/keyboard shortcut translation strings.
  • npmx-dev/npmx.dev#2902: Both PRs add/adjust command palette and keyboard-shortcut related strings in the same file.
  • npmx-dev/npmx.dev#2960: Both PRs update locale JSON to add/align command-palette and footer keyboard_shortcuts strings across languages.

Suggested reviewers: ghostdevv

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly matches the main change: updating Japanese i18n translations.
Description check ✅ Passed The description directly describes the change by noting newly added keys and missing Japanese translations.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch shuuji3/fix/update-japanese

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Jul 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@gameroman gameroman added the i18n Related to internationalization label Jul 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

i18n Related to internationalization

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants