-
-
Notifications
You must be signed in to change notification settings - Fork 277
Fix blender save #590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dfaust
wants to merge
2
commits into
notify-rs:main
Choose a base branch
from
dfaust:fix-blender-save
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+388
−124
Open
Fix blender save #590
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| use std::{ | ||
| path::{Path, PathBuf}, | ||
| time::Instant, | ||
| }; | ||
|
|
||
| /// An entry that holds back events at one path until an event at another path is emitted. | ||
| /// | ||
| /// Used to prevent events queued for a renamed path from being emitted before | ||
| /// the [`RenameMode::Both`](notify::event::RenameMode) event at the new path | ||
| /// has itself been emitted. | ||
| #[derive(Debug)] | ||
| pub struct BlockEntry { | ||
| /// Path whose queued event must be emitted first (the rename destination). | ||
| pub blocker_path: PathBuf, | ||
| /// Timestamp of the blocking event, used to match the exact rename event. | ||
| pub blocker_time: Instant, | ||
| /// Path whose events are held back until the blocker is emitted (the rename source). | ||
| pub blockee_path: PathBuf, | ||
| } | ||
|
|
||
| /// Tracks which paths have their event emission held back by a pending rename. | ||
| /// | ||
| /// When a rename `A → B` is queued, events already in A's queue must not be | ||
| /// emitted before the rename event at B. `BlockManager` records this | ||
| /// dependency so [`debounced_events`] can skip blocked paths until the | ||
| /// rename at the blocker path is emitted and [`remove_blocker`] is called. | ||
| /// | ||
| /// [`debounced_events`]: crate::DebounceDataInner::debounced_events | ||
| /// [`remove_blocker`]: BlockManager::remove_blocker | ||
| #[derive(Debug, Default)] | ||
| pub struct BlockManager { | ||
| pub entries: Vec<BlockEntry>, | ||
| } | ||
|
|
||
| impl BlockManager { | ||
| /// Construct an empty `BlockManager`. | ||
| pub fn new() -> BlockManager { | ||
| Self::default() | ||
| } | ||
|
|
||
| /// Register a new blocking relationship. | ||
| pub fn add_blocker(&mut self, entry: BlockEntry) { | ||
| self.entries.push(entry); | ||
| } | ||
|
|
||
| /// Remove the blocker for `path` at `time` once its event has been emitted. | ||
| pub fn remove_blocker(&mut self, path: &Path, time: Instant) { | ||
| self.entries | ||
| .retain(|entry| entry.blocker_path != *path || entry.blocker_time != time); | ||
| } | ||
|
|
||
| /// Return the blocker for `path`, if one exists. | ||
| /// | ||
| /// Returns `(blocker_path, blocker_time)` when `path`'s events are held | ||
| /// back, or `None` if `path` is not blocked. | ||
| pub fn is_blocked_by(&self, path: &Path) -> Option<(&PathBuf, Instant)> { | ||
| self.entries | ||
| .iter() | ||
| .find(|entry| entry.blockee_path == *path) | ||
| .map(|entry| (&entry.blocker_path, entry.blocker_time)) | ||
| } | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This comment was marked as resolved.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope. I'm specifically talking about the "safe" saving process where a new file is written first and then moved to the original location.