Skip to content

chore: switch replay commands to SDK endpoints - #482

Open
nieomylnieja wants to merge 11 commits into
mainfrom
switch-to-sdk-replay
Open

chore: switch replay commands to SDK endpoints#482
nieomylnieja wants to merge 11 commits into
mainfrom
switch-to-sdk-replay

Conversation

@nieomylnieja

@nieomylnieja nieomylnieja commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator

Motivation

The related Go SDK change includes a versioned Replay API. Sloctl no longer needs separate Replay HTTP requests and models.

Summary

  • Migrated Replay run, availability, status, list, cancel, and delete operations to sdk/endpoints/replay/v1.
  • Preserved SLO handling across API versions and restored project scope when API responses omit metadata.project.
  • Preserved source-SLO objective mappings and RFC3339 createdAt values in Replay list output.
  • Used only the SLO selector for availability checks, which prevents mutually exclusive SLO and data-source selector modes.
  • Pinned nobl9-go to v0.135.0-rc1.0.20260813210234-1ab7747b42f5 and updated the Go requirement to 1.26.6.

Related changes

Testing

  • Added CLI-level Bats coverage for project-scoped SLO responses that omit metadata.project and source-SLO mappings across projects.
  • Added list coverage for RFC3339 createdAt values and coarse Replay status values.
  • Added request-shape coverage for SLO-only availability, Replay creation, cancellation, targeted deletion, and deletion of all queued Replays.
  • Exercised the verified binary in a development environment through creation, JSON listing, terminal-state cancellation, targeted deletion, and cleanup.

Breaking Changes

Building sloctl from source now requires Go 1.26.6 instead of Go 1.26.5.

Replace custom replay HTTP requests with typed SDK replay and object APIs.
Updates the nobl9-go dependency and adds coverage for source SLO config parsing.
@github-actions github-actions Bot added the python label Aug 7, 2026
Replace manual manifest decoding with SDK types and add replay e2e coverage for project-scoped SLO resolution.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants