[ml service] Support flexible tensors for compatibility with filters like llama.cpp - #635
Conversation
d2911a9 to
0fe78c0
Compare
46df6bc to
6fdc295
Compare
|
Please rebase the branch |
|
Need a smaller unit test case. We execute all unit test cases for every PR, SR, build, ,.. |
6fdc295 to
0d952a8
Compare
Thank you. Rebase is completed. |
|
0d952a8 to
40e1488
Compare
anyj0527
left a comment
There was a problem hiding this comment.
LGTM👍 However there is a concern related with syncing nnstreamer to the tizen-unified. You may proceed the SR process of reflecting latest nnstreamer into the Tizen.
40e1488 to
c5abc2f
Compare
| g_free (hw_name); | ||
|
|
||
| if (info->invoke_dynamic) | ||
| single_h->format = _NNS_TENSOR_FORMAT_FLEXIBLE; |
There was a problem hiding this comment.
well, should we keep current format here?
How about updating information in single instance as flexible?
// updating below information as flexible
GstTensorsInfo in_info;
GstTensorsInfo out_info;
There was a problem hiding this comment.
Currently updating within the sub-plugin. We need to fix all sub-plugins. Is it a necessary discussion?
executorch_llama_subplugin::getModelInfo (
model_info_ops ops, GstTensorsInfo &in_info, GstTensorsInfo &out_info)
{
if (ops == GET_IN_OUT_INFO) {
in_info.num_tensors = 1;
in_info.format = _NNS_TENSOR_FORMAT_FLEXIBLE;
out_info.num_tensors = 1;
out_info.format = _NNS_TENSOR_FORMAT_FLEXIBLE;
return 0;
}
return -ENOENT;
}
6d101e2 to
3e012c5
Compare
…like llama.cpp - Refactor tensor allocation logic to support flexible tensor - Enable compatibility with filters such as llama.cpp by allowing dynamic tensor management Signed-off-by: hyunil park <hyunil46.park@samsung.com>
3e012c5 to
9583757
Compare
Uh oh!
There was an error while loading. Please reload this page.