don't block on git credential prompts during version discovery - #1816
Open
georgelemon wants to merge 1 commit into
Open
don't block on git credential prompts during version discovery#1816georgelemon wants to merge 1 commit into
georgelemon wants to merge 1 commit into
Conversation
Related to nim-lang#1814. Version discovery probes many candidate URLs, including historical ones whose repos may be deleted or renamed. For those, git would otherwise block on an interactive username/password prompt. During discovery, set GIT_TERMINAL_PROMPT=0 when it isn't already set by the user, so dead URLs fail fast and the version is excluded; restore the previous value afterwards so actual installs keep interactive prompts for private repositories.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #1814: Version discovery probes many candidate URLs, including historical ones whose repos may be deleted or renamed. For those, git would otherwise block on an interactive username/password prompt.
Force
GIT_TERMINAL_PROMPT=0(an explicit user-set value is respected) for the duration of discovery so dead URLs fail fast and the version is excluded, then restore the previous value so actual installs keep interactive prompts for private repositories