Handle empty dir in VCS type detection instead of crashing - #1704
Open
ZoomRmc wants to merge 1 commit into
Open
Conversation
When a dependency is referenced via `--path` (nim.cfg) and is not installed in nimble pkgs2, nimble creates a PackageInfo with an empty `myPath`. Calling `getVcsType` or `getVcsTypeAndSpecialDirPath` with this empty path raises an uncaught NimbleError, preventing `nimble dump` from producing output and breaking LSP integration. This fixes by returning `(vcsTypeNone, "")` for empty dir. An empty dir means "path unknown" - no VCS to detect. All callers handle `vcsTypeNone` gracefully already. Non-empty non-existent dirs (e.g. corrupted cache) still raise as before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a dependency is referenced via
--path(nim.cfg) and is not installed in nimble pkgs2, nimble creates a PackageInfo with an emptymyPath. CallinggetVcsTypeorgetVcsTypeAndSpecialDirPathwith this empty path raises an uncaught NimbleError, preventingnimble dumpfrom producing output and breaking LSP integration.This fixes by returning
(vcsTypeNone, "")for empty dir. An empty dir means "path unknown" - no VCS to detect. All callers handlevcsTypeNonegracefully already. Non-empty non-existent dirs (e.g. corrupted cache) still raise as before.