fixes #26050; preserve defer scope across when nimvm - #26067
Open
subotac wants to merge 1 commit into
Open
Conversation
Member
|
Adhoc logic, there's got to be a better way. |
subotac
force-pushed
the
fix/defer-nimvm-scope
branch
from
August 3, 2026 14:06
d847d7e to
7fd6b61
Compare
Contributor
Author
|
Agreed — I reworked this to split the same-scope control flow around each defer, including through retained |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #26050.
Preserve the enclosing statement-list tail when lifting
deferfromwhen nimvmbranches, so the deferred action runs at the end of the lexical scope in both native and VM execution.Adds native and VM regression coverage.