fix #25978: show call chain for forbids violations - #26005
Open
nimamasl114514 wants to merge 1 commit into
Open
Conversation
Replaces misleading 'template/generic instantiation from here' with '.forbids spec declared here' and traces the effect through the call graph to show where it originates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.forbidsviolations previously reported only the immediate call site with a misleading "template/generic instantiation from here" message, giving no indication of where the forbidden effect actually originates.This PR:
pushInfoContext(which produced the misleading template/generic message) with a direct ".forbids spec declared here" hinttraceForbidsOriginwhich walks the callee's effect list to trace the effect back through the call graph, emitting a hint at each hopBefore:
After:
The
raisespath is unchanged — onlyisForbidstakes the new code path.