fix #24521: propagate checkDir in static walkDir - #25983
Open
nimamasl114514 wants to merge 1 commit into
Open
Conversation
The nimvm/weirdTarget branch of walkDir forwarded to staticWalkDir
without the checkDir argument, so walkDir("missing", checkDir=true)
silently succeeded at compile time instead of raising OSError. Thread
checkDir through staticWalkDir and its vmop so the flag is honored.
nimamasl114514
force-pushed
the
fix-24521
branch
from
July 10, 2026 22:09
348042f to
ab5d236
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
checkDirparameter instaticWalkDirso that the static (VM) implementation matches the runtimewalkDirbehavior.staticWalkDirnow accepts an optionalcheckDir = falseargument, forwarded to the nativewalkDir.Fixes #24521