Repository navigation
feat(tui): show a running child's full task in the expanded widget - #3196
Merged
Merged
Conversation
Contributor
[Low impact] No blocking code defect was found, but exact-head CI must be verified before calling this merge-ready.
|
…orkflow children once, keep task layout (#3187)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While a background child runs, the expanded widget showed its task only as a one-line preview cut at 96 characters (
compactTaskText), the same as the collapsed row. A structured brief became an unreadable one-liner, and there was no expanded state that showed what the child had been asked to do.When exactly one child is running in the widget, the expanded row now shows the task as written: line breaks kept, wrapped to the terminal width, at most 8 lines plus a "…" line. The task is cut to what 8 lines can show before sanitizing and wrapping, so a very long task costs the same per frame as a short one; no I/O was added to the render path.
With two or more running children, each row keeps today's one-line preview. Review found that the longer block pushed the second running child's whole row past the widget's line budget (16 lines on a 30-row terminal), hiding running work. The collapsed widget is unchanged in both cases.
Scope reduced from #3187 on purpose:
Test:
test/unit/render-helpers.test.tscovers one running child (full task, width-bounded, joins back to the original at 80 columns, huge task capped), two running children (both rows visible, same line count as short tasks), and unchanged collapsed output. Full unit suite passes locally.Thanks to @marshamonkey25-hue for the report.
Closes #3187