Repository navigation
fix(lyrical): vendor packages need python3-pkg-resources on Fedora 45+ - #26
Merged
Merged
Conversation
gz_cmake_vendor and rviz_ogre_vendor failed on all four Python 3.15
chroots (fedora-45, fedora-rawhide) with
from pkg_resources import load_entry_point
ModuleNotFoundError: No module named 'pkg_resources'
raised by vcstool during the ExternalProject download step. Fedora 45
ships setuptools 83, which no longer carries pkg_resources; it moved to
the separate python3-pkg-resources package, and python3-vcstool does not
require it. Fedora 44 and CentOS Stream 10 still get pkg_resources from
setuptools.
Every vendor package runs vcs at build time through
ros-lyrical-ament-cmake-vendor-package, so that package now Requires
python3-pkg-resources behind an %if 0%{?fedora} >= 45 guard. Release
bumped to 2 so the dependency reaches the vendor buildroots. The stale
comment in the ogre-vendor spec is corrected to match.
Verified in fedora:45 and fedora:rawhide containers: vcs fails to import
without the package and runs with it. verify-specs: 0 errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
gz_cmake_vendorandrviz_ogre_vendorfail on all four Python 3.15 chroots (fedora-45-*,fedora-rawhide-*):raised by
vcsduring the ExternalProject download step.Cause
Fedora 45 ships setuptools 83, which no longer carries
pkg_resources. It moved to the separatepython3-pkg-resourcespackage, and Fedora'spython3-vcstooldoes not require it. Fedora 44 and CentOS Stream 10 still getpkg_resourcesfrom setuptools. Verified infedora:45andfedora:rawhidecontainers:vcs --versionfails without the package and works with it.Fix
Every vendor package runs
vcsat build time throughros-lyrical-ament-cmake-vendor-package, so that package now carriesRequires: python3-pkg-resourcesbehind%if 0%{?fedora} >= 45. Release bumped to 2. The stale comment in the ogre-vendor spec is corrected.Follow-up (not in this PR)
Rebuild
ros-lyrical-ament-cmake-vendor-package, then drive the rviz chain on the Python 3.15 chroots. If green, update the README, docs and COPR instructions that say rviz2 is absent there.