Fix callPackage still producing dynamic executables - #128
Open
FPtje wants to merge 1 commit into
Open
Conversation
FPtje
marked this pull request as draft
June 30, 2024 13:21
This was due to `staticHaskellBinariesOverlay` overlay changing every _existing_ package to build statically, but not every _new_ package called with `callPackage`.
FPtje
force-pushed
the
fp/fix-callPackage-dynamic-executables
branch
from
June 30, 2024 13:23
da65237 to
d0f4678
Compare
FPtje
commented
Jun 30, 2024
Comment on lines
+1712
to
+1716
| (final.lib.mapAttrs | ||
| (name: value: | ||
| if (isProperHaskellPackage value && isExecutable value) then statify value else value | ||
| ) | ||
| super | ||
| super) // { |
Collaborator
Author
There was a problem hiding this comment.
I was hoping I could get rid of this map, as the callPackage override would take over its functionality. That doesn't appear to happen, though, and leaving this out will cause any regular executables to be dynamically linked.
FPtje
marked this pull request as ready for review
June 30, 2024 14:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was due to
staticHaskellBinariesOverlayoverlay changing every existing package to build statically, but not every new package called withcallPackage.Here's an example building against my own
glualint:Before
After