Fix agent not logging collector logs to stdout by default in containers#1757
Open
karensantana wants to merge 2 commits into
Open
Fix agent not logging collector logs to stdout by default in containers#1757karensantana wants to merge 2 commits into
karensantana wants to merge 2 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1757 +/- ##
=======================================
Coverage 84.86% 84.87%
=======================================
Files 105 105
Lines 13632 13634 +2
=======================================
+ Hits 11569 11572 +3
+ Misses 1540 1537 -3
- Partials 523 525 +2
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Contributor
|
Think we can append a integration test for this in an existing suite since we use containers for testing. |
craigell
approved these changes
Jun 25, 2026
Contributor
Author
Perfect, I'll add that. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
When running in a container the agent collector logs are being written to disk instead of stdout. This change fixes this behavior so if a path is not specified in the config,
stdoutis used by default in containers.Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTINGdocumentmake install-toolsand have attached any dependency changes to this pull requestREADME.md)