fix(nextly): stop localized writes overwriting default-locale content by mobeenabdullah · Pull Request #382 · nextlyhq/nextly

mobeenabdullah · 2026-07-28T18:58:43Z

Closes the P0 found on published 0.0.2-alpha.43 during the alpha demo walk: enabling localization on a collection that already had content could silently destroy the default language.

The defect

ensureCompanionTable is the intended db:sync/dev-boot counterpart to migration-owned companion creation, and it works — but it was only ever called at boot, from di/register.ts.

nextly db:sync runs in a separate CLI process. It flips dynamic_collections.<slug>.localized to 1 and returns. So in the window between that and the next boot:

the already-running dev server reloads the registry, sees localized: 1, registers dc_posts_locales, and renders the complete localization UI — content-language switcher, "Shared" badges, Default: fallback hints, all correct;
the physical dc_posts_locales table does not exist;
a non-default-locale update falls through to the main table, overwriting the default language's values and regenerating the slug from the translation, reporting success.

Measured on alpha.43:

after db:sync, before restart:
  registry localized = 1
  locale tables in DB = []              <-- companion missing
  save es title -> dc_posts.title = "Cómo crear un blog con Nextly"
                   dc_posts.slug  = "cmo-crear-un-blog-con-nextly"
  (English title now only in a nextly_versions snapshot)

after restarting the dev server:
  locale tables = [dc_posts_locales]
  save en title -> dc_posts_locales(_locale='en', ...)   <-- correct

Every surface reports success: the CLI says "Schema applied — no changes", the admin renders a correct localization UI, and the save succeeds. The user believes they added a translation; they replaced their original-language content and changed its public URL.

The fix

1. Close the window. A new ensureLocalizedCompanions creates the _locales companion for every localized collection, single and component, called from db-sync.ts and from dev-watcher.ts (turning localization on is a config edit, so it arrives through HMR as often as through the CLI). It must run after all three syncs — a companion carries a foreign key to its main table, so running it earlier creates nothing for singles and components. Idempotent: one probe per localized entity.

2. Fail closed anyway. If the companion is somehow still missing, a non-default-locale update is refused with NextlyError.conflict and an actionable message rather than falling through to the main row. Collections and singles both (singles fail differently — the split drops the translation silently instead of overwriting).

Scoped to updates on purpose. A non-default-locale create legitimately writes to the main table until the companion exists — a new entry has no other language's values to lose — and that is the documented pre-migration fallback, asserted by writes-create.integration.test.ts.

3. Stop swallowing failures. ensureCompanionTable had a blanket catch {}, so a persistent failure was indistinguishable from first-boot ordering. It takes an optional onError reporter; db:sync logs a warning naming the entity and the consequence. Existing callers are unchanged.

Also included: a leftover P2 from #375 — resetWebhookRecordingPolicy zeroed the refresh generation, so a refresh still in flight could match a later boot's counter and republish a stale decision (ABA). The counter now only increases.

Verification

Every test below was run with its fix disabled and observed to fail.

Test	Without the fix
Two-boot SQLite transition (content starts on main, `es` update)	`expected true to be false` — the write silently succeeded and overwrote
Same scenario on sqlite / postgresql / mysql, single boot	`expected 500 to be 409` — an opaque driver error, not our refusal
`db:sync` creates a localized collection's companion	`expected false to be true`
`db:sync` creates a localized single's companion	`expected false to be true`
Non-localized collection gets no companion (negative control)	passes either way, as intended
`resetWebhookRecordingPolicy` ABA	stale refresh replaced the new boot's decisions

Only the two-boot case demonstrates data loss, because it is the only one where the translatable value starts on the main table. The dialect-parametrized cases prove the guard fires everywhere, which is the part that is dialect-sensitive: companionTableExists probes with dialect-quoted SQL, and on Postgres a failed statement inside a transaction poisons the rest of it.

3-dialect integration: SQLite, Postgres 17, MySQL, on freshly recreated databases.
check-types 0 errors, lint clean.

Not in this PR

Boot-detectable drift — reporting localized: 1 with no companion the way findCoreSchemaDrift reports missing columns. Item 4 of the task's fix list; stays open as a follow-up.
The one-line wiring into db-sync.ts and dev-watcher.ts is not covered by a test; the test drives the sequence directly.
migrate:create emitting a full schema on db:sync-managed projects, which is why the migration route was not a usable workaround during the walk. Filed separately.

Summary by CodeRabbit

New Features
- Localized companion tables are now created automatically during database synchronization, development rebuilds, and watch-mode updates.
- Existing default-language content is seeded into newly created localization tables without duplicating translations.
Bug Fixes
- Non-default-language updates are now safely rejected until localization tables are ready, preventing lost or overwritten translations.
- Improved handling of localization setup errors.
- Prevented stale webhook recording settings from overriding newer policy changes.

mobeenabdullah · 2026-07-28T18:58:51Z

@codex please review this PR

coderabbitai · 2026-07-28T18:58:52Z

Warning

Review limit reached

@mobeenabdullah, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 36 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 74598d10-62e1-46d0-8b0e-90fa34f6d8b2

📥 Commits

Reviewing files that changed from the base of the PR and between 38766c3 and 3a0c3f4.

⛔ Files ignored due to path filters (1)

.changeset/localized-write-companion-guard.md is excluded by !.changeset/**

📒 Files selected for processing (16)

packages/nextly/src/cli/commands/__tests__/db-sync-localized-companion.integration.test.ts
packages/nextly/src/cli/commands/db-sync.ts
packages/nextly/src/cli/commands/dev-build.ts
packages/nextly/src/cli/commands/dev-watcher.ts
packages/nextly/src/di/register.ts
packages/nextly/src/domains/collections/services/collection-mutation-service.ts
packages/nextly/src/domains/components/services/component-mutation-service.ts
packages/nextly/src/domains/i18n/__tests__/localized-write-without-companion.integration.test.ts
packages/nextly/src/domains/i18n/migration/generate-up.ts
packages/nextly/src/domains/i18n/runtime/companion-io.ts
packages/nextly/src/domains/i18n/writes-create.integration.test.ts
packages/nextly/src/domains/singles/__tests__/localized-single-without-companion.integration.test.ts
packages/nextly/src/domains/singles/services/single-mutation-service.ts
packages/nextly/src/domains/webhooks/__tests__/recording-policy.test.ts
packages/nextly/src/domains/webhooks/recording-policy.ts
packages/nextly/src/init/reload-config.ts

📝 Walkthrough

Walkthrough

The PR adds localized companion-table provisioning to CLI, watcher, and boot flows, seeds existing default-locale data, rejects unsafe localized writes when companions are missing, and fixes webhook recording generation resets with regression coverage.

Changes

Localized companion lifecycle

Layer / File(s)	Summary
Sync-time companion provisioning `packages/nextly/src/cli/commands/dev-build.ts`, `packages/nextly/src/cli/commands/db-sync.ts`, `packages/nextly/src/cli/commands/dev-watcher.ts`, `packages/nextly/src/cli/commands/__tests__/*`	Localized companions are ensured after collection, single, and component synchronization, with coverage for naming, ordering, localized entities, and non-localized entities.
Boot-time locale propagation `packages/nextly/src/di/register.ts`	The configured default locale is passed through schema initialization and code-first companion provisioning.
Companion reconciliation and seeding `packages/nextly/src/domains/i18n/runtime/companion-io.ts`, `packages/nextly/src/domains/i18n/migration/generate-up.ts`	Companion creation reports errors, detects remaining main-table columns, and seeds empty companions from default-locale values.
Missing-companion write guards `packages/nextly/src/domains/collections/services/collection-mutation-service.ts`, `packages/nextly/src/domains/singles/services/single-mutation-service.ts`, `packages/nextly/src/domains/i18n/__tests__/*`	Non-default-locale writes now return conflicts when companions are absent, while default-locale writes retain fallback behavior; integration tests cover transition and dialect scenarios.

Webhook recording generation

Layer / File(s)	Summary
Monotonic recording reset generation `packages/nextly/src/domains/webhooks/recording-policy.ts`, `packages/nextly/src/domains/webhooks/__tests__/recording-policy.test.ts`	Policy resets increment the generation counter, and tests verify stale refresh decisions are rejected.

Estimated code review effort: 4 (Complex) | ~60 minutes

Possibly related PRs

nextlyhq/nextly#172: Introduces related localized companion runtime and entity behavior.
nextlyhq/nextly#237: Establishes the localized companion schemas and tables used by this provisioning flow.
nextlyhq/nextly#303: Modifies related companion migration and seeding logic.

Suggested labels: scope: cli

Suggested reviewers: faisal-rx

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description explains the bug and fix, but it does not follow the required template sections like Type of change, Changeset, Test plan, or Checklist.	Add the template sections with checkboxes, mention the changeset status, and fill in related issues, test plan, checklist, and notes.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly matches the main change: preventing localized writes from overwriting default-locale content.
Docstring Coverage	✅ Passed	Docstring coverage is 90.91% which is sufficient. The required threshold is 80.00%.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch fix/localized-write-without-companion

🔧 Fix failing CI

Fix failing CI in branch fix/localized-write-without-companion

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

pkg-pr-new · 2026-07-28T19:01:14Z

Open in StackBlitz

@nextlyhq/adapter-drizzle

npm i https://pkg.pr.new/@nextlyhq/adapter-drizzle@3a0c3f4

@nextlyhq/adapter-mysql

npm i https://pkg.pr.new/@nextlyhq/adapter-mysql@3a0c3f4

@nextlyhq/adapter-postgres

npm i https://pkg.pr.new/@nextlyhq/adapter-postgres@3a0c3f4

@nextlyhq/adapter-sqlite

npm i https://pkg.pr.new/@nextlyhq/adapter-sqlite@3a0c3f4

@nextlyhq/admin

npm i https://pkg.pr.new/@nextlyhq/admin@3a0c3f4

@nextlyhq/admin-css

npm i https://pkg.pr.new/@nextlyhq/admin-css@3a0c3f4

@nextlyhq/blocks-engine

npm i https://pkg.pr.new/@nextlyhq/blocks-engine@3a0c3f4

create-nextly-app

npm i https://pkg.pr.new/create-nextly-app@3a0c3f4

nextly

npm i https://pkg.pr.new/nextly@3a0c3f4

@nextlyhq/plugin-form-builder

npm i https://pkg.pr.new/@nextlyhq/plugin-form-builder@3a0c3f4

@nextlyhq/plugin-page-builder

npm i https://pkg.pr.new/@nextlyhq/plugin-page-builder@3a0c3f4

@nextlyhq/plugin-sdk

npm i https://pkg.pr.new/@nextlyhq/plugin-sdk@3a0c3f4

@nextlyhq/plugin-seo

npm i https://pkg.pr.new/@nextlyhq/plugin-seo@3a0c3f4

@nextlyhq/storage-s3

npm i https://pkg.pr.new/@nextlyhq/storage-s3@3a0c3f4

@nextlyhq/storage-uploadthing

npm i https://pkg.pr.new/@nextlyhq/storage-uploadthing@3a0c3f4

@nextlyhq/storage-vercel-blob

npm i https://pkg.pr.new/@nextlyhq/storage-vercel-blob@3a0c3f4

@nextlyhq/ui

npm i https://pkg.pr.new/@nextlyhq/ui@3a0c3f4

commit: 3a0c3f4

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fe76865f50

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

mobeenabdullah · 2026-07-28T22:25:26Z

@codex please review this PR

coderabbitai

Actionable comments posted: 2

🧹 Nitpick comments (2)

packages/nextly/src/cli/commands/__tests__/db-sync-localized-companion.integration.test.ts (1)
157-181: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value

Consider covering a localized component too.

Components are the one kind whose dbName is honored verbatim (resolveComponentTableName), which is exactly the divergence the dbName test guards against for collections — but no case exercises the component branch of ensureLocalizedCompanions.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@packages/nextly/src/cli/commands/__tests__/db-sync-localized-companion.integration.test.ts`
around lines 157 - 181, Extend the localized companion integration coverage to
include a localized component with a custom dbName, exercising the component
branch of ensureLocalizedCompanions. Use resolveComponentTableName semantics by
asserting the companion table is derived from the verbatim component dbName, and
verify the incorrectly prefixed alternative is absent.
packages/nextly/src/domains/i18n/runtime/companion-io.ts (1)
246-252: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value

Doc block still claims failures are swallowed.

The behavior now reports through the optional onError (Lines 269–273, 312–322); "a failure ... is swallowed so it retries on the next boot" only holds for callers that omit the reporter. Worth qualifying so the contract reads consistently.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@packages/nextly/src/domains/i18n/runtime/companion-io.ts` around lines 246 -
252, Update the documentation for the companion creation flow near its
best-effort behavior to clarify that failures are reported through the optional
onError callback when provided, while callers omitting onError swallow the
failure and retry on the next boot. Keep the existing runtime behavior
unchanged.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@packages/nextly/src/di/register.ts`:
- Around line 476-479: Update the initializeSchemaRegistry call in the
surrounding registration flow to source localization.defaultLocale from
transformedConfig instead of config, preserving optional access. Align this
registry path with the existing ensureCompanionTable call sites that use
transformedConfig so plugin-transformed locale values are passed through.

In
`@packages/nextly/src/domains/i18n/__tests__/localized-write-without-companion.integration.test.ts`:
- Around line 12-15: Remove the sentence referencing “published alpha.43” and
“task 006” from the header comment in
localized-write-without-companion.integration.test.ts. Keep the preceding
explanation of the non-default-locale failure mode unchanged.

---

Nitpick comments:
In
`@packages/nextly/src/cli/commands/__tests__/db-sync-localized-companion.integration.test.ts`:
- Around line 157-181: Extend the localized companion integration coverage to
include a localized component with a custom dbName, exercising the component
branch of ensureLocalizedCompanions. Use resolveComponentTableName semantics by
asserting the companion table is derived from the verbatim component dbName, and
verify the incorrectly prefixed alternative is absent.

In `@packages/nextly/src/domains/i18n/runtime/companion-io.ts`:
- Around line 246-252: Update the documentation for the companion creation flow
near its best-effort behavior to clarify that failures are reported through the
optional onError callback when provided, while callers omitting onError swallow
the failure and retry on the next boot. Keep the existing runtime behavior
unchanged.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 88abd0d2-28d6-45aa-af92-7a0235dae530

📥 Commits

Reviewing files that changed from the base of the PR and between 0498e02 and 38766c3.

⛔ Files ignored due to path filters (1)

.changeset/localized-write-companion-guard.md is excluded by !.changeset/**

📒 Files selected for processing (12)

packages/nextly/src/cli/commands/__tests__/db-sync-localized-companion.integration.test.ts
packages/nextly/src/cli/commands/db-sync.ts
packages/nextly/src/cli/commands/dev-build.ts
packages/nextly/src/cli/commands/dev-watcher.ts
packages/nextly/src/di/register.ts
packages/nextly/src/domains/collections/services/collection-mutation-service.ts
packages/nextly/src/domains/i18n/__tests__/localized-write-without-companion.integration.test.ts
packages/nextly/src/domains/i18n/migration/generate-up.ts
packages/nextly/src/domains/i18n/runtime/companion-io.ts
packages/nextly/src/domains/singles/services/single-mutation-service.ts
packages/nextly/src/domains/webhooks/__tests__/recording-policy.test.ts
packages/nextly/src/domains/webhooks/recording-policy.ts

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 38766c3381

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

mobeenabdullah · 2026-07-29T00:26:32Z

@codex please review this PR

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: af53dbca1a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

mobeenabdullah · 2026-07-29T03:08:34Z

@codex please review this PR

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 61b30b4bac

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

mobeenabdullah · 2026-07-29T03:41:20Z

@codex please review this PR

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 30692efb2a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 43eaf6381e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

mobeenabdullah · 2026-07-29T05:25:42Z

@codex please review this PR

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ba79cfee62

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-07-29T05:33:55Z

+    await adapter.executeQuery(
+      `UPDATE ${companion} SET ${q(column)} = ` +
+        `(SELECT ${q(column)} FROM ${main} WHERE ${main}.${q("id")} = ${companion}.${q("_parent")}) ` +
+        `WHERE ${companion}.${q("_locale")} = ${placeholder}`,
+      [args.defaultLocale]


Create missing default-locale rows during field backfill

This UPDATE only backfills parents that already have a default-locale companion row. A document created solely in a non-default locale legitimately has no such row; if a previously shared main-table field is later marked localized, its new companion column remains null for that document and the main value disappears from localized reads. Backfill with a Drizzle insert/upsert that also creates missing default-locale rows while preserving existing translations.

AGENTS.md reference: AGENTS.md:L83-L85

Useful? React with 👍 / 👎.

Acknowledged, and not fixed — I would rather say that plainly than leave it looking handled.

You are right on the mechanism, and it is a consequence of my own previous fix, which is the reason I have stopped rather than continuing to patch. This is the sixth review round on this PR, and four of the six findings in it are regressions from fixes I made in the two rounds before — including the production ALTER TABLE path, which I introduced while fixing companion reconciliation.

The write-guard half of this PR has been stable since the first round. The seeding/transition half is an unattended data migration that has to infer state nobody recorded, and it has grown a new failure mode at a new seam in every round since it was added.

I have asked the maintainer to decide between landing the guard and moving the seeding work to its own PR, or continuing here. Reverting that scope is not my call to make unilaterally, so this thread stays open until they choose. If the answer is to continue here, this is one of the four I will pick up.

Confirmed, and not fixed — flagged rather than guessed at.

A document created only in a non-default language legitimately has no default-locale row, so the UPDATE has nothing to touch and a newly localized field's shared value never reaches it.

The insert half is straightforward on its own. What makes me want to do this deliberately rather than inline is that it interacts with the retryability question on the neighbouring thread and with the seed's "companion must be empty" rule: all three are the same underlying problem, which is that nothing records whether an entity's localization transition has completed, so each of these paths has to infer it from physical shape. Every inference this PR has added has needed a correction in the next review round.

Flagged to the maintainer as one of two remaining items.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 17c97d7eed

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-07-29T07:39:43Z

+        .filter(
+          column => !companionColumns.has(column) && mainColumns.has(column)
+        );


Make companion-column backfills retryable

If reconciliation successfully adds a companion column but backfillAddedCompanionColumns then fails—for example, due to a transient connection error or after the first of several column updates—the helper swallows the failure and a retry sees the column in companionColumns, so this filter permanently excludes it from backfill. Existing shared values remain on the main table but localized reads continue returning null for that field; track completion separately or make the add-and-backfill operation recoverable on subsequent runs.

Useful? React with 👍 / 👎.

Confirmed, and not fixed — flagging it rather than guessing.

The gap is real: if the column ADD succeeds and the backfill then fails, a retry sees the column in companionColumns and permanently excludes it, so the shared value stays on the main table while localized reads keep returning null.

What stops me shipping a fix is that the obvious retry conditions are unsafe in a way that matters. "Backfill whenever the default-locale value is null" would resurrect content a user had deliberately cleared, because once localized, writes go to the companion and the main column keeps its old value indefinitely. Distinguishing "never backfilled" from "cleared on purpose" needs state that nothing currently records.

Doing it properly means tracking transition completion explicitly rather than inferring it from the physical shape — which is the same conclusion your defaultLocale finding pushed the seed towards. I would rather do that as a deliberate piece of work than add another inference here; this PR has already had several fixes that moved a problem rather than solved it.

Flagged to the maintainer as one of two remaining items.

…-sync

…tion

…anion

mobeenabdullah · 2026-07-29T08:27:39Z

@codex please review this PR

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3a0c3f4f1b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-07-29T08:39:27Z

+    await adapter.executeQuery(
+      `UPDATE ${companion} SET ${q(column)} = ` +
+        `(SELECT ${q(column)} FROM ${main} WHERE ${main}.${q("id")} = ${companion}.${q("_parent")}) ` +
+        `WHERE ${companion}.${q("_locale")} = ${placeholder}`,


Route the backfill through Drizzle

This new runtime backfill assembles an UPDATE statement manually and sends it through executeQuery, bypassing the typed table descriptors and reimplementing dialect-specific quoting. Product database access in this repository is required to use Drizzle exclusively, so express this update with the companion and main Drizzle table objects instead.

AGENTS.md reference: AGENTS.md:L83-L85

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-07-29T08:39:27Z

    for (const stmt of statements) {
      await adapter.executeQuery(stmt);
    }


Backfill each added column before later DDL can fail

When reconciling an existing companion with multiple newly localized columns, every ALTER runs before any backfill; if a later statement or backfill fails after an earlier ADD COLUMN committed—particularly on MySQL—the catch returns successfully. On the next run, introspection treats that column as pre-existing and excludes it from added, so its shared main-table value is never copied and localized reads can remain null. Pair each additive statement with its backfill or otherwise retain enough state to retry incomplete backfills.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-07-29T08:39:27Z

+  //  - before the `!hasChanges` return, because that drop is classified unsafe and
+  //    deferred, which leaves `hasChanges` false — so the exact transition this
+  //    exists to support would return early and never provision anything.
+  await ensureLocalizedCompanionsForReload(adapter, newConfig);


Retry companion creation after HMR creates the main table

When an entirely new localized collection, single, or field group is added during HMR, this call runs before the schema pipeline creates its main table, so the companion's foreign-key creation fails and is swallowed by ensureCompanionTable. The later apply creates the main table, but this helper is never called again, while metadata and runtime schemas are still published as localized; non-default writes are therefore refused until another reload or restart. Keep the pre-apply call for seeding transitions, but run the idempotent provisioning again after a successful apply.

AGENTS.md reference: packages/nextly/AGENTS.md:L36-L40

Useful? React with 👍 / 👎.

github-actions Bot added scope: core nextly type: docs Documentation only labels Jul 28, 2026

chatgpt-codex-connector Bot reviewed Jul 28, 2026

View reviewed changes

Comment thread packages/nextly/src/cli/commands/dev-build.ts Outdated

Comment thread packages/nextly/src/domains/collections/services/collection-mutation-service.ts

Comment thread packages/nextly/src/cli/commands/dev-build.ts

coderabbitai Bot reviewed Jul 28, 2026

View reviewed changes

Comment thread packages/nextly/src/di/register.ts

Comment thread ...ages/nextly/src/domains/i18n/__tests__/localized-write-without-companion.integration.test.ts Outdated

chatgpt-codex-connector Bot reviewed Jul 28, 2026

View reviewed changes

chatgpt-codex-connector Bot reviewed Jul 29, 2026

View reviewed changes

mobeenabdullah force-pushed the fix/localized-write-without-companion branch from af53dbc to 61b30b4 Compare July 29, 2026 03:07

chatgpt-codex-connector Bot reviewed Jul 29, 2026

View reviewed changes

Comment thread packages/nextly/src/cli/commands/dev-watcher.ts

Comment thread packages/nextly/src/domains/i18n/runtime/companion-io.ts Outdated

Comment thread packages/nextly/src/cli/commands/db-sync.ts

Comment thread packages/nextly/src/domains/i18n/runtime/companion-io.ts Outdated

mobeenabdullah force-pushed the fix/localized-write-without-companion branch from 30692ef to 43eaf63 Compare July 29, 2026 04:55

chatgpt-codex-connector Bot reviewed Jul 29, 2026

View reviewed changes

Comment thread packages/nextly/src/init/reload-config.ts Outdated

Comment thread packages/nextly/src/domains/i18n/runtime/companion-io.ts Outdated

chatgpt-codex-connector Bot reviewed Jul 29, 2026

View reviewed changes

mobeenabdullah force-pushed the fix/localized-write-without-companion branch from ba79cfe to 17c97d7 Compare July 29, 2026 07:29

chatgpt-codex-connector Bot reviewed Jul 29, 2026

View reviewed changes

mobeenabdullah added 8 commits July 29, 2026 13:04

fix(nextly): keep the recording generation monotonic across resets

7fd0f4f

fix(nextly): stop localized writes overwriting default-locale content

56b9e5b

fix(nextly): seed the companion so existing content stays readable

e99a637

fix(nextly): backfill missing default-locale rows and respect no-auto…

6e7eb1d

…-sync

fix(nextly): seed only during the localization transition

659b21e

refactor(nextly): read companion shape through schema introspection

29e13e3

fix(nextly): provision companions on the reload path and guard produc…

22739a9

…tion

fix(nextly): carry a newly localized field's shared value to the comp…

fcced4e

…anion

mobeenabdullah added 3 commits July 29, 2026 13:04

fix(nextly): keep unattended companion reconciliation additive and gated

22902ab

fix(nextly): provision companions before the HMR schema apply

76bb930

fix(nextly): refuse localized field-group writes without a companion

3a0c3f4

mobeenabdullah force-pushed the fix/localized-write-without-companion branch from 17c97d7 to 3a0c3f4 Compare July 29, 2026 08:26

chatgpt-codex-connector Bot reviewed Jul 29, 2026

View reviewed changes

Uh oh!

Conversation

mobeenabdullah commented Jul 28, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

The defect

The fix

Verification

Not in this PR

Summary by CodeRabbit

Uh oh!

mobeenabdullah commented Jul 28, 2026

Uh oh!

coderabbitai Bot commented Jul 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review limit reached

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

pkg-pr-new Bot commented Jul 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mobeenabdullah commented Jul 28, 2026

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mobeenabdullah commented Jul 29, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mobeenabdullah commented Jul 29, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mobeenabdullah commented Jul 29, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

mobeenabdullah commented Jul 28, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jul 28, 2026 •

edited

Loading

pkg-pr-new Bot commented Jul 28, 2026 •

edited

Loading