[stable-34.0] Chore/improve clang tidy integration - #10743
Merged
Conversation
mgallien
marked this pull request as ready for review
September 7, 2026 12:22
mgallien
requested review from
camilasan,
claucambra and
i2h3
as code owners
September 7, 2026 12:22
removes code that would never be called Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Extract the inline -checks= list from the CI workflow into a .clang-tidy configuration file so the check set is discoverable outside CI and can be reused by local/IDE runs of clang-tidy. Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com> Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
also enforce it via clang-tidy configuration file Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
also add it to our configuration file to be enforced Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Broaden the clang-format requirement beyond ./src to all C++ source files, and add a mandatory run-clang-tidy -fix pass that must report no further changes before a task is considered done. Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com> Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
mgallien
force-pushed
the
backport/10666/stable-34.0
branch
from
September 7, 2026 12:23
d76f15c to
ef29e9c
Compare
feat(clang-tidy): enable CI to check clang-tidy conformance will use the .clang-tidy configuration file from the project should only publish comments and request changes when an existing file has issues Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
mgallien
force-pushed
the
backport/10666/stable-34.0
branch
from
September 7, 2026 12:24
ef29e9c to
c62d4fc
Compare
Contributor
|
Artifact containing the AppImage: nextcloud-appimage-pr-10743.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
|
claucambra
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #10666
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.