Skip to content

[stable-34.0] Feature/governance labels integration - #10353

Merged
mgallien merged 26 commits into
stable-34.0from
backport/10100/stable-34.0
Jul 13, 2026
Merged

[stable-34.0] Feature/governance labels integration#10353
mgallien merged 26 commits into
stable-34.0from
backport/10100/stable-34.0

feat(governance): deduplicate some code

7b60c61
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Jul 13, 2026 in 31m 11s

Quality Gate failed

Failed conditions
56.8% Coverage on New Code (required ≥ 80%)
95 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check failure on line 189 in src/gui/governance/governancelabelslistmodel.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add a "default" case to this switch statement. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9a2fSFADYbeZqcmXYx&open=AZ9a2fSFADYbeZqcmXYx&pullRequest=10353

Check failure on line 57 in src/gui/governance/typedgovernancenetworkjob.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add a "default" case to this switch statement. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9a2fS7ADYbeZqcmXZH&open=AZ9a2fS7ADYbeZqcmXZH&pullRequest=10353

Check warning on line 1300 in src/gui/socketapi/socketapi.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this identifier to be shorter or equal to 31 characters. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9a2fZ1ADYbeZqcmXZs&open=AZ9a2fZ1ADYbeZqcmXZs&pullRequest=10353

Check failure on line 55 in src/libsync/accessmanager.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add a "default" case to this switch statement. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9a2fcMADYbeZqcmXZz&open=AZ9a2fcMADYbeZqcmXZz&pullRequest=10353

Check warning on line 28 in src/gui/governance/getavailablegovernancelabels.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this access specifier; it does not affect any declaration. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9a2fRCADYbeZqcmXYg&open=AZ9a2fRCADYbeZqcmXYg&pullRequest=10353

Check warning on line 4 in src/gui/governance/getavailablegovernancelabels.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Edit this comment to use the C++ format, i.e. "//". 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9a2fVDADYbeZqcmXZd&open=AZ9a2fVDADYbeZqcmXZd&pullRequest=10353

Check failure on line 57 in src/gui/governance/typedgovernancenetworkjob.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor the code to eliminate this nested "switch". 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9a2fS7ADYbeZqcmXZG&open=AZ9a2fS7ADYbeZqcmXZG&pullRequest=10353

Check warning on line 25 in src/gui/governance/governancenetworkjob.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Class has 36 methods, which is greater than the 35 authorized. Split it into smaller classes. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9a2fTOADYbeZqcmXZJ&open=AZ9a2fTOADYbeZqcmXZJ&pullRequest=10353

Check warning on line 4 in src/gui/governance/getgovernancelabels.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Edit this comment to use the C++ format, i.e. "//". 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9a2fQgADYbeZqcmXYa&open=AZ9a2fQgADYbeZqcmXYa&pullRequest=10353

Check warning on line 317 in src/gui/governance/governancelabelslistmodel.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Declaration shadows a local variable "oneLabel" in the outer scope. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9a2fSFADYbeZqcmXYz&open=AZ9a2fSFADYbeZqcmXYz&pullRequest=10353

Check warning on line 4 in src/gui/governance/governancenetworkjob.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Edit this comment to use the C++ format, i.e. "//". 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9a2fTOADYbeZqcmXZI&open=AZ9a2fTOADYbeZqcmXZI&pullRequest=10353

Check warning on line 4 in src/gui/governance/typedgovernancenetworkjob.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Edit this comment to use the C++ format, i.e. "//". 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9a2fSqADYbeZqcmXY7&open=AZ9a2fSqADYbeZqcmXY7&pullRequest=10353

Check warning on line 92 in src/gui/governance/governancenetworkjob.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "newJob" of type "class QPointer<class OCC::OcsGovernanceJob>" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9a2fTOADYbeZqcmXZK&open=AZ9a2fTOADYbeZqcmXZK&pullRequest=10353

Check failure on line 53 in src/gui/governance/governancelabelslistmodel.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the default argument initializers. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9a2fTuADYbeZqcmXZN&open=AZ9a2fTuADYbeZqcmXZN&pullRequest=10353

Check failure on line 37 in src/gui/governance/typedgovernancenetworkjob.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add a "default" case to this switch statement. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9a2fS7ADYbeZqcmXZD&open=AZ9a2fS7ADYbeZqcmXZD&pullRequest=10353

Check warning on line 4 in src/gui/governance/governancelabelslistmodel.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Edit this comment to use the C++ format, i.e. "//". 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9a2fTuADYbeZqcmXZM&open=AZ9a2fTuADYbeZqcmXZM&pullRequest=10353

Check warning on line 53 in src/libsync/accessmanager.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This lambda has 27 lines, which is greater than the 20 lines authorized. Split it into several lambdas or functions, or make it a named function. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9a2fcMADYbeZqcmXZx&open=AZ9a2fcMADYbeZqcmXZx&pullRequest=10353

Check warning on line 318 in src/gui/governance/governancelabelslistmodel.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Declaration shadows a local variable "oneLabelObject" in the outer scope. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9a2fSFADYbeZqcmXY0&open=AZ9a2fSFADYbeZqcmXY0&pullRequest=10353

Check warning on line 4 in src/gui/governance/typedwithlabelidgovernancenetworkjob.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Edit this comment to use the C++ format, i.e. "//". 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9a2fRUADYbeZqcmXYh&open=AZ9a2fRUADYbeZqcmXYh&pullRequest=10353

Check warning on line 333 in src/gui/governance/governancelabelslistmodel.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Declaration shadows a local variable "oneLabel" in the outer scope. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9a2fSFADYbeZqcmXY1&open=AZ9a2fSFADYbeZqcmXY1&pullRequest=10353

Check failure on line 56 in src/gui/governance/governancelabelslistmodel.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add a "default" case to this switch statement. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9a2fSFADYbeZqcmXYu&open=AZ9a2fSFADYbeZqcmXYu&pullRequest=10353

Check warning on line 15 in src/gui/governance/deletegovernancelabel.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "parent" of type "class QObject *" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9a2fVWADYbeZqcmXZh&open=AZ9a2fVWADYbeZqcmXZh&pullRequest=10353

Check warning on line 334 in src/gui/governance/governancelabelslistmodel.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Declaration shadows a local variable "oneLabelObject" in the outer scope. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9a2fSFADYbeZqcmXY2&open=AZ9a2fSFADYbeZqcmXY2&pullRequest=10353

Check warning on line 4 in src/gui/governance/governancenetworkjob.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Edit this comment to use the C++ format, i.e. "//". 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9a2fUBADYbeZqcmXZP&open=AZ9a2fUBADYbeZqcmXZP&pullRequest=10353

Check warning on line 185 in src/gui/governance/governancenetworkjob.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "reply" of type "class QJsonDocument" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9a2fUBADYbeZqcmXZX&open=AZ9a2fUBADYbeZqcmXZX&pullRequest=10353
View more details on SonarQubeCloud