Skip to content

fix: load existing accounts before creating a new one - #10325

Merged
mgallien merged 1 commit into
masterfrom
bugfix/automatedAccountCreation
Jul 8, 2026
Merged

fix: load existing accounts before creating a new one#10325
mgallien merged 1 commit into
masterfrom
bugfix/automatedAccountCreation

fix: load existing accounts before creating a new one

7d7718e
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Jul 8, 2026 in 24m 43s

Quality Gate failed

Failed conditions
D Security Rating on New Code (required ≥ A)
E Maintainability Rating on New Code (required ≥ A)
16 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check failure on line 715 in src/gui/application.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this TOCTOU race condition window when accessing files 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9Ce3ngG5cpcpcN_mlh&open=AZ9Ce3ngG5cpcpcN_mlh&pullRequest=10325

Check failure on line 312 in src/gui/application.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this TOCTOU race condition window when accessing files 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9Ce3ngG5cpcpcN_mlb&open=AZ9Ce3ngG5cpcpcN_mlb&pullRequest=10325

Check failure on line 626 in src/gui/application.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace the use of "new" with an operation that automatically manages the memory. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9Ce3ngG5cpcpcN_mle&open=AZ9Ce3ngG5cpcpcN_mle&pullRequest=10325

Check warning on line 1285 in src/gui/application.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace the redundant type with "auto". 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9Ce3ngG5cpcpcN_mlr&open=AZ9Ce3ngG5cpcpcN_mlr&pullRequest=10325

Check warning on line 732 in src/gui/application.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This function should be declared "const". 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9Ce3ngG5cpcpcN_mli&open=AZ9Ce3ngG5cpcpcN_mli&pullRequest=10325

Check warning on line 811 in src/gui/application.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this identifier to be shorter or equal to 31 characters. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9Ce3ngG5cpcpcN_mlk&open=AZ9Ce3ngG5cpcpcN_mlk&pullRequest=10325

Check warning on line 1235 in src/gui/application.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Merge this "if" statement with the enclosing one. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9Ce3ngG5cpcpcN_mlp&open=AZ9Ce3ngG5cpcpcN_mlp&pullRequest=10325

Check warning on line 1174 in src/gui/application.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use the init-statement to declare "configLanguage" inside the if statement. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9Ce3ngG5cpcpcN_mln&open=AZ9Ce3ngG5cpcpcN_mln&pullRequest=10325

Check warning on line 332 in src/gui/application.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace "->" with "::" for access to "Theme::doNotUseProxy". 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9Ce3ngG5cpcpcN_mlc&open=AZ9Ce3ngG5cpcpcN_mlc&pullRequest=10325

Check warning on line 998 in src/gui/application.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Avoid this unnecessary copy by using a "const" reference. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9Ce3ngG5cpcpcN_mlm&open=AZ9Ce3ngG5cpcpcN_mlm&pullRequest=10325

Check warning on line 811 in src/gui/application.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This function should be declared "const". 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9Ce3ngG5cpcpcN_mll&open=AZ9Ce3ngG5cpcpcN_mll&pullRequest=10325

Check warning on line 127 in src/gui/application.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use the init-statement to declare "shouldTryToMigrate" inside the if statement. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9Ce3ngG5cpcpcN_mlZ&open=AZ9Ce3ngG5cpcpcN_mlZ&pullRequest=10325

Check failure on line 719 in src/gui/application.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this code to not nest more than 3 if|for|do|while|switch statements. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9Ce3ngG5cpcpcN_mlg&open=AZ9Ce3ngG5cpcpcN_mlg&pullRequest=10325

Check warning on line 680 in src/gui/application.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This function should be declared "const". 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9Ce3ngG5cpcpcN_mlf&open=AZ9Ce3ngG5cpcpcN_mlf&pullRequest=10325

Check failure on line 324 in src/gui/application.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this TOCTOU race condition window when accessing files 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9Ce3ngG5cpcpcN_mla&open=AZ9Ce3ngG5cpcpcN_mla&pullRequest=10325

Check warning on line 441 in src/gui/application.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace "->" with "::" for access to "Theme::doNotUseProxy". 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9Ce3ngG5cpcpcN_mld&open=AZ9Ce3ngG5cpcpcN_mld&pullRequest=10325

Check warning on line 1227 in src/gui/application.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Merge this "if" statement with the enclosing one. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9Ce3ngG5cpcpcN_mlq&open=AZ9Ce3ngG5cpcpcN_mlq&pullRequest=10325

Check warning on line 734 in src/gui/application.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "cfg" of type "class OCC::ConfigFile" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9Ce3ngG5cpcpcN_mlj&open=AZ9Ce3ngG5cpcpcN_mlj&pullRequest=10325

Check failure on line 1226 in src/gui/application.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this code to not nest more than 3 if|for|do|while|switch statements. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9Ce3ngG5cpcpcN_mlo&open=AZ9Ce3ngG5cpcpcN_mlo&pullRequest=10325
View more details on SonarQubeCloud